From 06b2192aa2bb6698c863388c5d085ba5b1f28374 Mon Sep 17 00:00:00 2001 From: Tim Foley Date: Mon, 9 Oct 2017 13:38:33 -0700 Subject: Preprocessor: fix `undef` and redefinition (#204) * Preprocessor: fix `undef` and redefinition The logic for `undef` directives was failing to suppress macro expansion when reading the name to un-define, and so it wasn't actually working at all. We didn't notice this because we didn't have a test case, and users hadn't tried it. The logic for `define` had a similar bug, which meant that any attempt to define an already-defined macro would fail with a cryptic error, rather than raising the intended warning. Test cases have been added for both issues, along with the fixes. * fixup: add expected output for tests added --- tests/preprocessor/undef.slang.expected | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 tests/preprocessor/undef.slang.expected (limited to 'tests/preprocessor/undef.slang.expected') diff --git a/tests/preprocessor/undef.slang.expected b/tests/preprocessor/undef.slang.expected new file mode 100644 index 000000000..2f7026487 --- /dev/null +++ b/tests/preprocessor/undef.slang.expected @@ -0,0 +1,6 @@ +result code = 0 +standard error = { +tests/preprocessor/undef.slang(5): warning 15401: macro 'FOO' is not defined +} +standard output = { +} -- cgit v1.2.3