From adaea0e993fd8db351b5dad92802e47ed6d0ec77 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 17 Aug 2022 23:08:34 -0700 Subject: Warning on lossy implicit casts. (#2367) * Warning on bool to float conversion. * Fix test cases. * Improve. * LanguageServer: don't show constant value for non constant variables. * Fix tests. * Fix warnings in tests. Co-authored-by: Yong He --- tests/pipeline/compute/compute-system-values.slang | 8 ++++---- tests/pipeline/rasterization/fragment-shader-interlock.slang | 4 ++-- tests/pipeline/ray-tracing/trace-ray-inline.slang | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'tests/pipeline') diff --git a/tests/pipeline/compute/compute-system-values.slang b/tests/pipeline/compute/compute-system-values.slang index c63ca7f6b..a71bc0651 100644 --- a/tests/pipeline/compute/compute-system-values.slang +++ b/tests/pipeline/compute/compute-system-values.slang @@ -19,10 +19,10 @@ void computeMain( value = value*16 + groupIndex; value = value*16 + groupID.x; value = value*16 + groupID.y; - value = value*16 + groupThreadID.x; - value = value*16 + groupThreadID.y; - value = value*16 + dispatchThreadID.x; - value = value*16 + dispatchThreadID.y; + value = value*16 + int(groupThreadID.x); + value = value*16 + int(groupThreadID.y); + value = value*16 + int(dispatchThreadID.x); + value = value*16 + int(dispatchThreadID.y); outputBuffer[tid] = value; } \ No newline at end of file diff --git a/tests/pipeline/rasterization/fragment-shader-interlock.slang b/tests/pipeline/rasterization/fragment-shader-interlock.slang index 66597a9a8..7215629a2 100644 --- a/tests/pipeline/rasterization/fragment-shader-interlock.slang +++ b/tests/pipeline/rasterization/fragment-shader-interlock.slang @@ -13,8 +13,8 @@ void main( { beginInvocationInterlock(); - result = texture[coords.xy]; - texture[coords.xy] = result + coords; + result = texture[uint2(coords.xy)]; + texture[uint2(coords.xy)] = result + coords; endInvocationInterlock(); } diff --git a/tests/pipeline/ray-tracing/trace-ray-inline.slang b/tests/pipeline/ray-tracing/trace-ray-inline.slang index 6bbc776c5..d44500e18 100644 --- a/tests/pipeline/ray-tracing/trace-ray-inline.slang +++ b/tests/pipeline/ray-tracing/trace-ray-inline.slang @@ -132,7 +132,7 @@ void main(uint3 tid : SV_DispatchThreadID) { query.CommitProceduralPrimitiveHit(tHit); committedProceduralAttrs = candidateProceduralAttrs; - if(shouldStopAtFirstHit) + if(shouldStopAtFirstHit != 0) query.Abort(); } } @@ -144,7 +144,7 @@ void main(uint3 tid : SV_DispatchThreadID) if(myTriangleAnyHit(payload)) { query.CommitNonOpaqueTriangleHit(); - if(shouldStopAtFirstHit) + if(shouldStopAtFirstHit != 0) query.Abort(); } } -- cgit v1.2.3