From 45b76418f9da2248b069f2058c6a1d52b05a8c74 Mon Sep 17 00:00:00 2001 From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Date: Wed, 14 Aug 2024 13:05:57 -0400 Subject: Do not zero-initialize groupshared and rayquery variables (#4838) * Do not zero-initialize groupshared and rayquery variables Fixes: #4824 `-zero-initialize` option will explicitly not: 1. Set any groupshared values to defaults 2. Set any rayQuery object to a default state (currently invalid code generation) * grammer * disallow groupshared initializers disallow groupshared initializers & adjust tests accordingly * remove disallowed groupshared-init expression * do not default init if non-copyable --------- Co-authored-by: Yong He --- tests/metal/groupshared-threadlocal-same-parameter.slang | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests/metal/groupshared-threadlocal-same-parameter.slang') diff --git a/tests/metal/groupshared-threadlocal-same-parameter.slang b/tests/metal/groupshared-threadlocal-same-parameter.slang index ae4cac8df..1249d4703 100644 --- a/tests/metal/groupshared-threadlocal-same-parameter.slang +++ b/tests/metal/groupshared-threadlocal-same-parameter.slang @@ -6,7 +6,7 @@ //TEST_INPUT:ubuffer(data=[0 0], stride=4):out,name outputBuffer RWStructuredBuffer outputBuffer; -static groupshared uint g_values[2] = { 1, 0 }; +static groupshared uint g_values[2]; static uint g_altValues[2] = { 2, 3 }; static groupshared uint g_valuesReturned[2]; @@ -27,6 +27,7 @@ uint[2] maybeGroupSharedReturn(uint id) [numthreads(2, 1, 1)] void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) { + g_values = { 1, 0 }; AllMemoryBarrierWithGroupSync(); uint tid = dispatchThreadID.x; if (tid == 0) -- cgit v1.2.3