From 7758625d3fea67e55e98e7e4103d56c9918365be Mon Sep 17 00:00:00 2001
From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com>
Date: Fri, 29 Aug 2025 15:52:34 -0700
Subject: [CBP] Pointer frontend changes + groupshared pointer support (#7848)

Resolves #7628
Resolves: #8197

Primary Goals:
1. Add `Access` to pointer
2. AddressSpace::GroupShared support for pointers (SPIR-V)
3. Add `__getAddress()` to replace `&`
* `&` is not updated to `require(cpu)` since slangpy uses `&`. This
means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3)
add `require(cpu)` to `&`

Changes:
* Added to `Ptr` the `Access` generic argument & logic (for
`Access::Read`).
* Moved the generic argument `AddressSpace` from `Ptr` to the end of the
type.
* Added pointer casting support between any `Ptr` as long as the
`AddressSpace` is the same
* Disallow globallycoherent T* and coherent T*
* Disallow const T*, T const*, and const T*
* Fixed .natvis display of `ConstantValue` `ValOperandNode`
* Support generic resolution of type-casted integers
* Added `VariablePointer` emitting for spirv + other minor logic needed
for groupshared pointers

Breaking Changes:
* Anyone using the `AddressSpace` of `Ptr` will now have to account for
the `Access` argument
* we disallow various syntax paired with `Ptr` and `T*`

---------

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
---
 .../pointer/get-address-validation.slang           | 82 ++++++++++++++++++++++
 1 file changed, 82 insertions(+)
 create mode 100644 tests/language-feature/pointer/get-address-validation.slang

(limited to 'tests/language-feature/pointer/get-address-validation.slang')

diff --git a/tests/language-feature/pointer/get-address-validation.slang b/tests/language-feature/pointer/get-address-validation.slang
new file mode 100644
index 000000000..3931c13a2
--- /dev/null
+++ b/tests/language-feature/pointer/get-address-validation.slang
@@ -0,0 +1,82 @@
+//TEST:SIMPLE(filecheck=CHECK):-stage compute -entry computeMain -target spirv
+
+// Tests for invalid/valid use of `__getAddress`
+
+struct DeviceStruct
+{
+    int data1;
+    int data2;
+}
+
+struct StructPtrInStruct
+{
+    DeviceStruct* ptr;
+}
+
+uniform int* bufferUserPointer;
+RWStructuredBuffer<int> bufferStorage;
+groupshared int bufferGroupShared[100];
+uniform DeviceStruct* bufferUserPointerStruct;
+uniform int2* bufferUserPointerVector;
+
+int* output;
+
+typealias GroupSharedPtr<T> = Ptr<T, Access::ReadWrite, AddressSpace::GroupShared>;
+
+GroupSharedPtr<T> paramGroupShared<T : __BuiltinIntegerType>(out groupshared T[100] ptr)
+{
+    // CHECK: ([[# @LINE+1]]): error 30019
+    T* ptr1 = __getAddress(ptr[5]);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    GroupSharedPtr<T> ptr2 = __getAddress(ptr[5]);
+
+    return ptr2;
+}
+
+[numthreads(1, 1, 1)]
+void computeMain(int id : SV_DispatchThreadID)
+{
+    // CHECK: ([[# @LINE+1]]): error 31160
+    int* ptr1 = __getAddress(bufferStorage[id.x]);
+
+    // CHECK ([[# @LINE+1]]): error
+    int[100]* ptr2 = __getAddress(bufferGroupShared);
+
+    // CHECK: ([[# @LINE+1]]): error
+    int* ptr3 = __getAddress(bufferGroupShared[id.x]);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    int* ptr4 = __getAddress(bufferUserPointer[id.x]);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    GroupSharedPtr<int[100]> ptr5 = __getAddress(bufferGroupShared);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    GroupSharedPtr<int> ptr6 = __getAddress(bufferGroupShared[id.x]);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    GroupSharedPtr<int> ptr7 = paramGroupShared(bufferGroupShared);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    int* ptr8 = __getAddress(bufferUserPointerStruct.data1);
+
+    StructPtrInStruct structPtrInStruct;
+    structPtrInStruct.ptr = bufferUserPointerStruct;
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    int* ptr9 = __getAddress(structPtrInStruct.ptr[id.x].data1);
+
+    // CHECK-NOT: ([[# @LINE+1]]): error
+    int* ptr10 = __getAddress(bufferUserPointerVector[0].x);
+
+    output[id] = ptr1[id];
+    output[id] = ptr2[id][0];
+    output[id] = ptr3[id];
+    output[id] = ptr4[id];
+    output[id] = ptr5[id];
+    output[id] = ptr6[id];
+    output[id] = ptr7[id];
+    output[id] = ptr8[id];
+    output[id] = ptr9[id];
+    output[id] = ptr10[id];
+}
-- 
cgit v1.2.3