From 7758625d3fea67e55e98e7e4103d56c9918365be Mon Sep 17 00:00:00 2001 From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Date: Fri, 29 Aug 2025 15:52:34 -0700 Subject: [CBP] Pointer frontend changes + groupshared pointer support (#7848) Resolves #7628 Resolves: #8197 Primary Goals: 1. Add `Access` to pointer 2. AddressSpace::GroupShared support for pointers (SPIR-V) 3. Add `__getAddress()` to replace `&` * `&` is not updated to `require(cpu)` since slangpy uses `&`. This means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3) add `require(cpu)` to `&` Changes: * Added to `Ptr` the `Access` generic argument & logic (for `Access::Read`). * Moved the generic argument `AddressSpace` from `Ptr` to the end of the type. * Added pointer casting support between any `Ptr` as long as the `AddressSpace` is the same * Disallow globallycoherent T* and coherent T* * Disallow const T*, T const*, and const T* * Fixed .natvis display of `ConstantValue` `ValOperandNode` * Support generic resolution of type-casted integers * Added `VariablePointer` emitting for spirv + other minor logic needed for groupshared pointers Breaking Changes: * Anyone using the `AddressSpace` of `Ptr` will now have to account for the `Access` argument * we disallow various syntax paired with `Ptr` and `T*` --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- tests/language-feature/capability/address-of.slang | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 tests/language-feature/capability/address-of.slang (limited to 'tests/language-feature/capability') diff --git a/tests/language-feature/capability/address-of.slang b/tests/language-feature/capability/address-of.slang new file mode 100644 index 000000000..924312b0e --- /dev/null +++ b/tests/language-feature/capability/address-of.slang @@ -0,0 +1,17 @@ +//TEST:SIMPLE(filecheck=CHECK_FAIL): -target glsl -entry computeMain -stage compute +//TEST:SIMPLE(filecheck=CHECK_PASS): -target spirv -entry computeMain -stage compute + +// Test that __getAddress correctly reports capabilities. + +uniform int* outputBuffer; +uniform int* buffer; + +// CHECK_PASS: OpEntryPoint +// CHECK_PASS-NOT: error + +// CHECK_FAIL: ([[# @LINE+1]]): error 36107{{.*}}glsl +void computeMain() +{ + // CHECK: ([[# @LINE+1]]): note: see using of '__getAddress' + outputBuffer[0] = *(__getAddress(buffer[0])); +} \ No newline at end of file -- cgit v1.2.3