From f55f669d1badc94eb4eabf77a22a5994acca7a89 Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Thu, 25 Sep 2025 10:06:29 -0700 Subject: Fix VVL errors on coopvec tests (#8541) It appears that the inputType of the coopvec-mat-mul cannot be signed int32. It could be floating types or signed int32. Changing the tests to use uint32 instead of int32. The spec guarantees the following combinations and the rest should be queried at the runtime if it is supported by the HW. https://registry.khronos.org/vulkan/specs/latest/man/html/VkCooperativeVectorPropertiesNV.html#_description inputType | inputInterpretation | matrixInterpretation | biasInterpretation | resultType -- | -- | -- | -- | -- FLOAT16 | FLOAT16 | FLOAT16 | FLOAT16 | FLOAT16 UINT32 | SINT8_PACKED | SINT8 | SINT32 | SINT32 SINT8 | SINT8 | SINT8 | SINT32 | SINT32 FLOAT32 | SINT8 | SINT8 | SINT32 | SINT32 FLOAT16 | FLOAT_E4M3 | FLOAT_E4M3 | FLOAT16 | FLOAT16 FLOAT16 | FLOAT_E5M2 | FLOAT_E5M2 | FLOAT16 | FLOAT16 --- tests/expected-failure-github.txt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'tests/expected-failure-github.txt') diff --git a/tests/expected-failure-github.txt b/tests/expected-failure-github.txt index 6346a4f1f..6c2600beb 100644 --- a/tests/expected-failure-github.txt +++ b/tests/expected-failure-github.txt @@ -1,3 +1,5 @@ +# CoopVec tests failures are due to a bug in old VulkanSDK version 1.4.313.0 or below. +# When we upgrade VulkanSDK version on all CI machines, they should be removed from this list. tests/cooperative-vector/matrix-mul-bias-mut.slang (vk) tests/cooperative-vector/matrix-mul-bias-packed-mut.slang (vk) tests/cooperative-vector/matrix-mul-bias-packed.slang (vk) @@ -15,10 +17,7 @@ tests/cooperative-vector/matrix-mul-rw.slang (vk) tests/cooperative-vector/matrix-mul-rwbyteaddress-packed.slang (vk) tests/cooperative-vector/matrix-mul-structuredbuffer-packed.slang (vk) tests/cooperative-vector/matrix-mul.slang (vk) -tests/cooperative-vector/outer-product-structuredbuffer.slang (vk) -tests/cooperative-vector/outer-product.slang (vk) -tests/cooperative-vector/reduce-sum-accumulate-structuredbuffer.slang.3 syn (cuda) -tests/cooperative-vector/reduce-sum-accumulate.slang.3 syn (cuda) + tests/language-feature/saturated-cooperation/simple.slang (vk) tests/language-feature/saturated-cooperation/fuse3.slang (vk) tests/language-feature/saturated-cooperation/fuse-product.slang (vk) -- cgit v1.2.3