From e40ddc6efb275a753a46f8c8bcc420801668c931 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Wed, 9 Jul 2025 16:05:22 +0000 Subject: Fix internal error when a generic in an extension is unused (#7665) * Initial plan * Add diagnostic for unreferenced generic parameters in extensions Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Use GenericTypeParamDeclBase and eliminate intermediate list Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Update test to use filecheck format for better verification Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Update extension validation to use getMembersOfType for better constraint collection Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Add temporary workaround for inheritance constraints but issue persists Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix inheritance constraint validation by moving to SemanticsDeclConformancesVisitor Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix inheritance constraint validation by removing inheritance declaration checks Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Move extension generic parameter validation back to SemanticsDeclBasesVisitor Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix test. * format code (#7671) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> * Fix and update. * Refine fix. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> Co-authored-by: Yong He Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- .../extension-unreferenced-generic-param.slang | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 tests/diagnostics/extension-unreferenced-generic-param.slang (limited to 'tests/diagnostics') diff --git a/tests/diagnostics/extension-unreferenced-generic-param.slang b/tests/diagnostics/extension-unreferenced-generic-param.slang new file mode 100644 index 000000000..80aba4adb --- /dev/null +++ b/tests/diagnostics/extension-unreferenced-generic-param.slang @@ -0,0 +1,26 @@ +//TEST:SIMPLE(filecheck=CHECK): -target spirv +// Test unreferenced generic parameters in extensions + +// Error case 1: Simple unreferenced generic parameter +// CHECK: ([[# @LINE+1]]): error 30855: +extension int +{ + void foo() {} +} + +// Error case 2: Multiple generic parameters, some unused +// CHECK: ([[# @LINE+1]]): error 30855: +extension vector +{ + void bar() {} +} + +// Error case 3: Parameters only used in inheritance declaration should be errors +interface IFooGeneric {} +struct MyType {} + +// CHECK: ([[# @LINE+1]]): error 30855: +extension MyType : IFooGeneric +{ + void shouldFail() {} +} -- cgit v1.2.3