From 45b76418f9da2248b069f2058c6a1d52b05a8c74 Mon Sep 17 00:00:00 2001 From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Date: Wed, 14 Aug 2024 13:05:57 -0400 Subject: Do not zero-initialize groupshared and rayquery variables (#4838) * Do not zero-initialize groupshared and rayquery variables Fixes: #4824 `-zero-initialize` option will explicitly not: 1. Set any groupshared values to defaults 2. Set any rayQuery object to a default state (currently invalid code generation) * grammer * disallow groupshared initializers disallow groupshared initializers & adjust tests accordingly * remove disallowed groupshared-init expression * do not default init if non-copyable --------- Co-authored-by: Yong He --- tests/diagnostics/uninitialized-globals.slang | 7 ------- 1 file changed, 7 deletions(-) (limited to 'tests/diagnostics') diff --git a/tests/diagnostics/uninitialized-globals.slang b/tests/diagnostics/uninitialized-globals.slang index 635db1e29..730b0343f 100644 --- a/tests/diagnostics/uninitialized-globals.slang +++ b/tests/diagnostics/uninitialized-globals.slang @@ -1,15 +1,8 @@ //TEST:SIMPLE(filecheck=CHK): -allow-glsl -target spirv // Using groupshared variables -groupshared float4 gsConstexpr = float4(1.0f); groupshared float4 gsUninitialized; -// OK -float use_constexpr_initialized_gs() -{ - return gsConstexpr.x; -} - float use_undefined_gs() { //CHK-DAG: ([[# @LINE + 1]]): warning 41017: use of uninitialized global variable 'gsUninitialized' -- cgit v1.2.3