From cdfea42f1b28c6ec7b13500a64be823f67bf8e0a Mon Sep 17 00:00:00 2001 From: Ellie Hermaszewska Date: Fri, 7 Jul 2023 03:52:00 +0800 Subject: Fix erroneous error claiming variable is being used before its declaration (#2958) * Simplify type of diagnoseImpl * Show source line for Note diagnostics, opting out of this where appropriate * Make declared after use diagnostic clearer * Fix erroneous error claiming variable is being used before its declaration Closes https://github.com/shader-slang/slang/issues/2936 * Fix build on msvc --------- Co-authored-by: jsmall-nvidia --- tests/diagnostics/parameter-already-defined.slang.expected | 2 ++ 1 file changed, 2 insertions(+) (limited to 'tests/diagnostics/parameter-already-defined.slang.expected') diff --git a/tests/diagnostics/parameter-already-defined.slang.expected b/tests/diagnostics/parameter-already-defined.slang.expected index fa9ffb581..42156a020 100644 --- a/tests/diagnostics/parameter-already-defined.slang.expected +++ b/tests/diagnostics/parameter-already-defined.slang.expected @@ -4,6 +4,8 @@ tests/diagnostics/parameter-already-defined.slang(4): error 30200: declaration o int foo( int a, float a ) { return 0; } ^ tests/diagnostics/parameter-already-defined.slang(4): note: see previous declaration of 'a' +int foo( int a, float a ) { return 0; } + ^ } standard output = { } -- cgit v1.2.3