From 21a66267c661a55c8ad27248c0765276dd6f72ea Mon Sep 17 00:00:00 2001 From: Gangzheng Tong Date: Tue, 15 Jul 2025 16:39:22 -0700 Subject: Emit additional diagnostic for invalid pointer taking operations (#7663) * Emit special diagnostic for invalid pointer taking operations * Update source/slang/slang-diagnostic-defs.h Co-authored-by: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> * Add OperatorAddressOf KnownBuiltin modifier * update error message for non-l-value assignment * update the diagnostics in the tests * Use enum based KnownBuiltinDeclName * format code (#7772) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --------- Co-authored-by: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- tests/diagnostics/methods/mutating-method-on-rvalue.slang.expected | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests/diagnostics/methods') diff --git a/tests/diagnostics/methods/mutating-method-on-rvalue.slang.expected b/tests/diagnostics/methods/mutating-method-on-rvalue.slang.expected index fdf04e6b4..d9694276b 100644 --- a/tests/diagnostics/methods/mutating-method-on-rvalue.slang.expected +++ b/tests/diagnostics/methods/mutating-method-on-rvalue.slang.expected @@ -3,10 +3,11 @@ standard error = { tests/diagnostics/methods/mutating-method-on-rvalue.slang(13): error 30050: mutating method 'increment' cannot be called on an immutable value increment(); ^ -tests/diagnostics/methods/mutating-method-on-rvalue.slang(13): note 30049: a 'this' parameter is an immutable parameter by default in Slang; apply the `[mutating]` attribute to the function declaration to opt in to a mutable `this` +tests/diagnostics/methods/mutating-method-on-rvalue.slang(13): note 30049: attempting to assign to a const variable or immutable member; use '[mutating]' attribute on the containing method to allow modification tests/diagnostics/methods/mutating-method-on-rvalue.slang(25): error 30050: mutating method 'increment' cannot be called on an immutable value gCounter.increment(); ^ +tests/diagnostics/methods/mutating-method-on-rvalue.slang(25): note 30049: attempting to assign to a const variable or immutable member; use '[mutating]' attribute on the containing method to allow modification } standard output = { } -- cgit v1.2.3