From adaea0e993fd8db351b5dad92802e47ed6d0ec77 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 17 Aug 2022 23:08:34 -0700 Subject: Warning on lossy implicit casts. (#2367) * Warning on bool to float conversion. * Fix test cases. * Improve. * LanguageServer: don't show constant value for non constant variables. * Fix tests. * Fix warnings in tests. Co-authored-by: Yong He --- tests/diagnostics/constexpr-error.slang | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tests/diagnostics/constexpr-error.slang') diff --git a/tests/diagnostics/constexpr-error.slang b/tests/diagnostics/constexpr-error.slang index f0de9280d..a5b98264b 100644 --- a/tests/diagnostics/constexpr-error.slang +++ b/tests/diagnostics/constexpr-error.slang @@ -21,7 +21,7 @@ float4 main() : SV_Target float4 result = 0.0f; // Okay, immediate constant - result += t.Sample(s, uv, uint2(0,0)); + result += t.Sample(s, uv, int2(0,0)); // Error: data passed through cbuffer isn't compile-time constant result += t.Sample(s, uv, offset); @@ -32,13 +32,13 @@ float4 main() : SV_Target { ii = 1; } - result += t.Sample(s, uv, uint2(ii)); + result += t.Sample(s, uv, int2(ii)); // Error: data computed in loop isn't compile-time constant // (and loop isn't unroll-able) for(uint jj = 0; jj < uv.y; jj++) { - result += t.Sample(s, uv, uint2(jj)); + result += t.Sample(s, uv, int2(jj)); } return result; -- cgit v1.2.3