From 2580bb02f7a079ab1c0106b5960a21ed1627bca0 Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Thu, 15 May 2025 03:47:43 +0000 Subject: Add new coopmat2 functions: Reduce and Transpose (#7027) This commit adds three new functions for CoopMat as described in the proposal document, Cooperative matrix 2 proposal spec#12 The new functions are: CoopMat::Transpose CoopMat::ReduceRow CoopMat::ReduceColumn CoopMat::ReduceRowAndColumn CoopMat::Reduce2x2 --- .../diagnostics/mat-mul-add-different-scope.slang | 20 -------------------- .../mat-mul-add-incorrect-matrix-use.slang | 20 -------------------- 2 files changed, 40 deletions(-) delete mode 100644 tests/cooperative-matrix/diagnostics/mat-mul-add-different-scope.slang delete mode 100644 tests/cooperative-matrix/diagnostics/mat-mul-add-incorrect-matrix-use.slang (limited to 'tests/cooperative-matrix/diagnostics') diff --git a/tests/cooperative-matrix/diagnostics/mat-mul-add-different-scope.slang b/tests/cooperative-matrix/diagnostics/mat-mul-add-different-scope.slang deleted file mode 100644 index 0c4308308..000000000 --- a/tests/cooperative-matrix/diagnostics/mat-mul-add-different-scope.slang +++ /dev/null @@ -1,20 +0,0 @@ -//DIAGNOSTIC_TEST(compute):SIMPLE(filecheck=CHECK): -entry computeMain -stage compute -target spirv - -RWStructuredBuffer outputBuffer; - -typealias CoopMatAType = CoopMat; -typealias CoopMatBType = CoopMat; -typealias CoopMatCType = CoopMat; - -// CHECK: error 39999: could not specialize generic for arguments of type - -[numthreads(32, 1, 1)] -void computeMain() -{ - let matA = CoopMatAType(3.0); - let matB = CoopMatBType(5.0); - let matC = CoopMatCType(1.0); - - const let result = coopMatMulAdd(matA, matB, matC, CoopMatMatrixOperands::None); - result.store(outputBuffer, 0, 16, CoopMatMatrixLayout::RowMajor); -} diff --git a/tests/cooperative-matrix/diagnostics/mat-mul-add-incorrect-matrix-use.slang b/tests/cooperative-matrix/diagnostics/mat-mul-add-incorrect-matrix-use.slang deleted file mode 100644 index 5b7dc7a5b..000000000 --- a/tests/cooperative-matrix/diagnostics/mat-mul-add-incorrect-matrix-use.slang +++ /dev/null @@ -1,20 +0,0 @@ -//DIAGNOSTIC_TEST(compute):SIMPLE(filecheck=CHECK): -entry computeMain -stage compute -target spirv - -RWStructuredBuffer outputBuffer; - -typealias CoopMatAType = CoopMat; -typealias CoopMatBType = CoopMat; -typealias CoopMatCType = CoopMat; - -// CHECK: error 41400: static assertion failed, matrix uses for `coopMatMulAdd` matrix parameters must be `MatrixA`, `MatrixB` and `MatrixAccumulator` - -[numthreads(32, 1, 1)] -void computeMain() -{ - let matA = CoopMatAType(3.0); - let matB = CoopMatBType(5.0); - let matC = CoopMatCType(1.0); - - let result = coopMatMulAdd(matA, matB, matC, CoopMatMatrixOperands::None); - result.store(outputBuffer, 0, 16, CoopMatMatrixLayout::RowMajor); -} -- cgit v1.2.3