From 6f523dd95d1f16003c7ed1d4a9e1da0cba0ea76c Mon Sep 17 00:00:00 2001 From: Theresa Foley Date: Thu, 11 Nov 2021 13:45:23 -0800 Subject: Fix two test cases that were causing problems (#2011) First, we have a CUDA-only test that simply needed a format name to be changed to match the new conventions in `gfx`. Second, we have one of the "active mask" tests that seems to produce different results locally for developers (under Vulkan) than it does on CI. This is almost certainly down to differences in GPUs and/or drivers. The inconsistency ultimately proves the point that I was trying to make when I wrote those tests - the "active mask" concept is effectively meaningless as exposed in D3D and Vulkan because it has not been specified in a way that allows programmers to reason about its value, and drivers have implemented wildly different interpretations of its supposed semantics for so long that there is no real hope of turning `WaveGetActiveMask()` into something that returns a well-defined value in any but the most trivial cases. TLDR: I disabled that test for Vulkan, which means it is completely disabled. --- tests/compute/half-texture-simple.slang | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'tests/compute') diff --git a/tests/compute/half-texture-simple.slang b/tests/compute/half-texture-simple.slang index 75bd6b3ad..124755534 100644 --- a/tests/compute/half-texture-simple.slang +++ b/tests/compute/half-texture-simple.slang @@ -7,23 +7,23 @@ //TEST(compute):COMPARE_COMPUTE_EX:-cuda -compute -shaderobj // Doesn't work on CUDA, not clear why yet -//DISABLE_TEST_INPUT: Texture1D(format=R_Float16, size=4, content = one, mipMaps=1):name tLoad1D +//DISABLE_TEST_INPUT: Texture1D(format=R16_FLOAT, size=4, content = one, mipMaps=1):name tLoad1D //Texture1D tLoad1D; -//TEST_INPUT: Texture1D(format=R_Float16, size=4, content = one):name t1D +//TEST_INPUT: Texture1D(format=R16_FLOAT, size=4, content = one):name t1D Texture1D t1D; -//TEST_INPUT: Texture2D(format=R_Float16, size=4, content = one):name t2D +//TEST_INPUT: Texture2D(format=R16_FLOAT, size=4, content = one):name t2D Texture2D t2D; -//TEST_INPUT: Texture3D(format=R_Float16, size=4, content = one):name t3D +//TEST_INPUT: Texture3D(format=R16_FLOAT, size=4, content = one):name t3D Texture3D t3D; -//TEST_INPUT: TextureCube(format=R_Float16, size=4, content = one):name tCube +//TEST_INPUT: TextureCube(format=R16_FLOAT, size=4, content = one):name tCube TextureCube tCube; -//TEST_INPUT: Texture1D(format=R_Float16, size=4, content = one, arrayLength=2):name t1DArray +//TEST_INPUT: Texture1D(format=R16_FLOAT, size=4, content = one, arrayLength=2):name t1DArray Texture1DArray t1DArray; -//TEST_INPUT: Texture2D(format=R_Float16, size=4, content = one, arrayLength=2):name t2DArray +//TEST_INPUT: Texture2D(format=R16_FLOAT, size=4, content = one, arrayLength=2):name t2DArray Texture2DArray t2DArray; -//TEST_INPUT: TextureCube(format=R_Float16, size=4, content = one, arrayLength=2):name tCubeArray +//TEST_INPUT: TextureCube(format=R16_FLOAT, size=4, content = one, arrayLength=2):name tCubeArray TextureCubeArray tCubeArray; //TEST_INPUT: Sampler:name samplerState -- cgit v1.2.3