From 48efc60380aa79e8c4aba13976cc2015f38a659e Mon Sep 17 00:00:00 2001 From: Gangzheng Tong Date: Tue, 29 Jul 2025 12:12:40 -0700 Subject: Fix Metal invalid as_type cast for 64-bit RWByteAddressBuffer.Store values (#7843) * Fix 64-bit val lowering for metal * Add ByteAddressBuffer load/store 64-bit tests * Handle Store/Load ptr types * Use bitcast for non-pointer typers * format code (#7966) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --------- Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- tests/compute/byte-address-buffer-64bit.slang | 32 ++++++++++++++++++++++ .../byte-address-buffer-64bit.slang.expected.txt | 8 ++++++ 2 files changed, 40 insertions(+) create mode 100644 tests/compute/byte-address-buffer-64bit.slang create mode 100644 tests/compute/byte-address-buffer-64bit.slang.expected.txt (limited to 'tests/compute') diff --git a/tests/compute/byte-address-buffer-64bit.slang b/tests/compute/byte-address-buffer-64bit.slang new file mode 100644 index 000000000..e8d6a42f2 --- /dev/null +++ b/tests/compute/byte-address-buffer-64bit.slang @@ -0,0 +1,32 @@ +// byte-address-buffer.slang + +//TEST(compute):COMPARE_COMPUTE_EX:-cpu -compute -shaderobj +//TEST(compute):COMPARE_COMPUTE_EX:-d3d12 -compute -shaderobj -profile cs_6_0 -use-dxil +//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj + +//TEST_INPUT:ubuffer(data=[0 1 2 3]):name=inputBuffer +RWByteAddressBuffer inputBuffer; + +//TEST_INPUT:ubuffer(data=[0 0 0 0 0 0 0 0]):out,name=outputBuffer +RWByteAddressBuffer outputBuffer; + +void testInt64(uint val) +{ + // Load a 32-bit value from the input buffer + uint tmp = inputBuffer.Load(uint(val * 4)); + + // Cast to uint64_t + uint64_t tmp64 = uint64_t(tmp) + 1; + + // Store the result back as uint64_t + outputBuffer.Store(uint(val * 8), tmp64); +} + +[numthreads(4, 1, 1)] +[shader("compute")] +void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) +{ + uint tid = dispatchThreadID.x; + + testInt64(tid); +} diff --git a/tests/compute/byte-address-buffer-64bit.slang.expected.txt b/tests/compute/byte-address-buffer-64bit.slang.expected.txt new file mode 100644 index 000000000..ac5027985 --- /dev/null +++ b/tests/compute/byte-address-buffer-64bit.slang.expected.txt @@ -0,0 +1,8 @@ +1 +0 +2 +0 +3 +0 +4 +0 \ No newline at end of file -- cgit v1.2.3