From 05547e25353dd797791c2937679468d529d832d5 Mon Sep 17 00:00:00 2001
From: venkataram-nv <vedavamadath@nvidia.com>
Date: Tue, 16 Jul 2024 14:54:53 -0700
Subject: Warnings function parameters (#4626)

* Handle out/inout functions with separate consideration

* Fixing bug with passing aliasable instructions

* Handle autodiff functions (fwd and rev) in warning system

* Handling interface methods

* Handling ref parameters like out/inout

* Temporary fix to remaining bugs

* Refactoring methods and tests

* Recursive check for empty structs

* Using default initializable interface in tests

* Resolving CI fail
---
 tests/compute/assoctype-func-param.slang    | 4 ++--
 tests/compute/assoctype-nested-lookup.slang | 4 ++--
 tests/compute/dynamic-dispatch-17.slang     | 4 ++--
 tests/compute/empty-struct2.slang           | 6 +++---
 tests/compute/generic-closer.slang          | 4 ++--
 tests/compute/generic-default-arg.slang     | 4 ++--
 tests/compute/transitive-interface.slang    | 4 ++--
 7 files changed, 15 insertions(+), 15 deletions(-)

(limited to 'tests/compute')

diff --git a/tests/compute/assoctype-func-param.slang b/tests/compute/assoctype-func-param.slang
index 830cc00cc..6d6bf5b6d 100644
--- a/tests/compute/assoctype-func-param.slang
+++ b/tests/compute/assoctype-func-param.slang
@@ -37,7 +37,7 @@ struct GenStruct<T> : IBase
 
 U.RetT test<U:IBase>(U.RetT val)
 {
-    U obj;
+    U obj = U();
     U.SubTypeT sb = obj.setVal(val);
     return obj.getVal(sb);
 }
@@ -50,4 +50,4 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
     /* wrong error message for the following line */
     float outVal = test<GenStruct<float> >(inVal);
     outputBuffer[tid] = outVal.x;
-}
\ No newline at end of file
+}
diff --git a/tests/compute/assoctype-nested-lookup.slang b/tests/compute/assoctype-nested-lookup.slang
index b1ca75d49..64a5d29a5 100644
--- a/tests/compute/assoctype-nested-lookup.slang
+++ b/tests/compute/assoctype-nested-lookup.slang
@@ -12,7 +12,7 @@ interface IFoo : IDefaultInitializable
 };
 
 
-struct FooPair<T : IFoo> : IFoo
+struct FooPair<T : IFoo> : IFoo, IDefaultInitializable
 {
     T a;
     T.Bar b;
@@ -41,4 +41,4 @@ void computeMain(uint3 dispatchThreadID: SV_DispatchThreadID)
 {
     FooPair<ConcreteFoo>.Bar pair;
     test(pair);
-}
\ No newline at end of file
+}
diff --git a/tests/compute/dynamic-dispatch-17.slang b/tests/compute/dynamic-dispatch-17.slang
index bc2b9a6d9..e89482a5b 100644
--- a/tests/compute/dynamic-dispatch-17.slang
+++ b/tests/compute/dynamic-dispatch-17.slang
@@ -52,7 +52,7 @@ struct FloatVal : IInterface
     float val;
     float run<Z:IReturnsZero>()
     {
-        Z z;
+        Z z = Z();
         return val + z.get();
     }
 };
@@ -62,7 +62,7 @@ struct Float4Val : IInterface
     Float4Struct val;
     float run<Z:IReturnsZero>()
     {
-        Z z;
+        Z z = Z();
         return val.val.x + val.val.y + z.get();
     }
 };
diff --git a/tests/compute/empty-struct2.slang b/tests/compute/empty-struct2.slang
index 27e587b42..303cfd234 100644
--- a/tests/compute/empty-struct2.slang
+++ b/tests/compute/empty-struct2.slang
@@ -25,8 +25,8 @@ struct EmptyS : IEmptyS
 struct Empty<TT : IEmptyS> : IInterface
 {
     typedef TT T;
-    TT value;
-    float a;
+    TT value = TT();
+    float a = 0;
     TT getT()
     {
         return value;
@@ -51,4 +51,4 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
     Empty<EmptyS> obj;
     test(obj);
     outputBuffer[dispatchThreadID.x] = dispatchThreadID.x;
-}
\ No newline at end of file
+}
diff --git a/tests/compute/generic-closer.slang b/tests/compute/generic-closer.slang
index 377b42dab..c497b14d0 100644
--- a/tests/compute/generic-closer.slang
+++ b/tests/compute/generic-closer.slang
@@ -13,7 +13,7 @@ struct Gen0 : IGetter
 };
 struct Gen1<TGetter : IGetter> : IGetter
 {
-    TGetter g;
+    TGetter g = TGetter();
     int get() { return g.get(); }
 };
 
@@ -39,4 +39,4 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
     int b = 5;
     if (a< b && b > a)
 	    outputBuffer[dispatchThreadID.x] = (g.get() >> 1) + g2.get() + g3.get();
-}
\ No newline at end of file
+}
diff --git a/tests/compute/generic-default-arg.slang b/tests/compute/generic-default-arg.slang
index 8762f5e8a..3a3a4a5b8 100644
--- a/tests/compute/generic-default-arg.slang
+++ b/tests/compute/generic-default-arg.slang
@@ -31,7 +31,7 @@ struct Impl2 : ITest
 __generic<T : ITest = Impl1>
 struct GenStruct
 {
-	T obj;
+	T obj = T();
 };
 
 int test(GenStruct gs, int val)
@@ -50,4 +50,4 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
 	outVal += test(gs, tid);
 
 	outputBuffer[tid] = outVal;
-}
\ No newline at end of file
+}
diff --git a/tests/compute/transitive-interface.slang b/tests/compute/transitive-interface.slang
index e4d7db91d..d8b167bd7 100644
--- a/tests/compute/transitive-interface.slang
+++ b/tests/compute/transitive-interface.slang
@@ -47,7 +47,7 @@ struct AssocImpl : IAssoc
 
 int testAdd2<T:IAssoc>(T assoc)
 {
-    T.AT obj;
+    T.AT obj = T.AT();
     return obj.addf(1, 1);
 }
 
@@ -69,4 +69,4 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
     outVal += testSub(s1, outVal);
 
 	outputBuffer[dispatchThreadID.x] = outVal;
-}
\ No newline at end of file
+}
-- 
cgit v1.2.3