From 0360f81b9741ece65768a65731bd23455a3b7a96 Mon Sep 17 00:00:00 2001 From: Tim Foley Date: Fri, 2 Feb 2018 08:49:04 -0800 Subject: Remove support for the -no-checking flag (#392) * Remove support for the -no-checking flag Fixes #381 Fixes #383 Work on #382 - No longer expose flag through API (`SLANG_COMPILE_FLAG_NO_CHECKING`) and command-line (`-no-checking`) options - Remove all logic in `check.cpp` that was withholding diagnostics (including errors) when the no-checking mode was enabled - Remove `HiddenImplicitCastExpr`, which was only created to support no-checking mode (it represented an implicit cast that our checking through was needed, but couldn't emit because it might be wrong) - Remove logic for storing function bodies as raw token lists when checking is turned off. I'm leaving in the `UnparsedStmt` AST node in case we ever need/want to lazily parse and check function bodies down the line. - Remove a few of the code-generation paths we had to contend with, but keep the comment about them in place. - Remove GLSL-based tests that can't meaningfully work with the new approach. - Fix other tests that used a GLSL baseline so that their GLSL compiles with `-pass-through glslang` instead of invoking `slang` with the `-no-checking` flag. - Remove tests that were explicitly added to test the "rewriter + IR" path, since that is no longer supported. There is more cleanup that can be done here, now that we know that AST-based rewrite and IR will never co-exist, but it is probably easier to deal with that as part of removing the AST-based rewrite path. We've lost some test coverage here, but actually not too much if we consider that we are dropping GLSL input anyway. * Fixup: test runner was mis-counting ignored tests * Fixup: turn on dumping on test failure under Travis * Fixup: enable extensions in Linux build of glslang --- tests/compute/rewriter-array-type.hlsl | 35 ---------------------------------- 1 file changed, 35 deletions(-) delete mode 100644 tests/compute/rewriter-array-type.hlsl (limited to 'tests/compute/rewriter-array-type.hlsl') diff --git a/tests/compute/rewriter-array-type.hlsl b/tests/compute/rewriter-array-type.hlsl deleted file mode 100644 index 38a2abc1e..000000000 --- a/tests/compute/rewriter-array-type.hlsl +++ /dev/null @@ -1,35 +0,0 @@ -//TEST(compute):HLSL_COMPUTE:-xslang -no-checking -xslang -use-ir - -//TEST_INPUT:cbuffer(data=[16 0 0 0 32 0 0 0]):dxbinding(0),glbinding(0) -//TEST_INPUT:cbuffer(data=[256 0 0 0 512 0 0 0 768 0 0 0 1024 0 0 0]):dxbinding(1),glbinding(1) -//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):dxbinding(0),glbinding(0),out -//TEST_INPUT:ubuffer(data=[90 91 92 93], stride=4):dxbinding(1),glbinding(1) -//TEST_INPUT:ubuffer(data=[0 1 2 3], stride=4):dxbinding(2),glbinding(2) - -// Test the case of user code with that uses the "rewriter" mode -// (`-no-checking` flag) and that uses a type declared in -// imported code (that will compile via IR). Also test -// the case where such a type requires legalization. - -import rewriter_types; - -RWStructuredBuffer outputBuffer : register(u0); - -cbuffer C -{ - MyHelper myHelpers[2]; -} - -cbuffer D -{ - Other others[2]; -} - -[numthreads(4, 1, 1)] -void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) -{ - uint tid = dispatchThreadID.x; - int inVal = tid; - int outVal = test(inVal, myHelpers[1], others[tid]); - outputBuffer[tid] = outVal; -} \ No newline at end of file -- cgit v1.2.3