From 3247174cdb00836435794e3f07daad70bc92b66f Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Wed, 22 May 2019 12:00:21 -0400 Subject: Hotfix/improve glsl semantic conversion review (#968) * Small changes based on review * Remove the explicit 'nominal' tests * Made isValueEqual and isEqual on on IRConstant take a pointer * Small improvements to comments, and clarity of using 'nominal' * Simplify comparison by just using isTypeOperandEqual as basis for isTypeEqual * Use cross compile to test half-texture.slang on glsl * Don't need half-texture.slang.expected * Fix handling of nominal comparison based on review, ensuring that for nominal insts, they can only be compared by pointer. --- tests/compute/half-texture.slang | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/compute/half-texture.slang') diff --git a/tests/compute/half-texture.slang b/tests/compute/half-texture.slang index 635336c66..3f2c5500e 100644 --- a/tests/compute/half-texture.slang +++ b/tests/compute/half-texture.slang @@ -1,4 +1,4 @@ -//TEST:SIMPLE: -target spirv -entry computeMain -profile cs_6_2 +//TEST:CROSS_COMPILE: -target spirv -entry computeMain -profile cs_6_2 //TEST:SIMPLE: -target hlsl -entry computeMain -profile cs_6_2 //TEST_INPUT:ubuffer(data=[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0], stride=16):dxbinding(0),glbinding(0),out -- cgit v1.2.3