From c94ca1692e101df87215232e87fa7edadc1a7b05 Mon Sep 17 00:00:00 2001 From: Ellie Hermaszewska Date: Tue, 1 Jul 2025 23:36:02 +0800 Subject: Allow Link time constant array length sizing, warn on unsupported functionality (#7067) * Add link time array layout test * Add link time constant array size compilation test * Link time constant array size test * Allow getting link time array size Closes https://github.com/shader-slang/slang/issues/6753 * format * Switch to SIMPLE test and check output * Implement without binary api changes * diagnose on link time constant sized array * fix test --------- Co-authored-by: Yong He --- tests/bugs/link-time-constant-array-size-lib.slang | 1 + .../bugs/link-time-constant-array-size-main.slang | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 tests/bugs/link-time-constant-array-size-lib.slang create mode 100644 tests/bugs/link-time-constant-array-size-main.slang (limited to 'tests/bugs') diff --git a/tests/bugs/link-time-constant-array-size-lib.slang b/tests/bugs/link-time-constant-array-size-lib.slang new file mode 100644 index 000000000..cc83c30fa --- /dev/null +++ b/tests/bugs/link-time-constant-array-size-lib.slang @@ -0,0 +1 @@ +export static const int N = 1597463007; diff --git a/tests/bugs/link-time-constant-array-size-main.slang b/tests/bugs/link-time-constant-array-size-main.slang new file mode 100644 index 000000000..da58decaf --- /dev/null +++ b/tests/bugs/link-time-constant-array-size-main.slang @@ -0,0 +1,22 @@ +//TEST:COMPILE: tests/bugs/link-time-constant-array-size-lib.slang -o tests/bugs/link-time-constant-array-size-lib.slang-module +//TEST:COMPILE: tests/bugs/link-time-constant-array-size-main.slang -o tests/bugs/link-time-constant-array-size-main.slang-module +//TEST:SIMPLE(filecheck=SPIRV): -r tests/bugs/link-time-constant-array-size-main.slang-module -r tests/bugs/link-time-constant-array-size-lib.slang-module -target spirv -o out.spv -stage compute -entry computeMain + +extern static const int N; + +// SPIRV: ([[# @LINE+1]]): warning 31000 +struct S { int xs[N]; } + +RWStructuredBuffer b; + +ParameterBlock p; + +[numthreads(1, 1, 1)] +void computeMain() +{ + // check that we multiply by our special number + // SPIRV: [[fisqr:%[a-zA-Z0-9_]+]] = OpConstant %int 1597463007 + // SPIRV: {{%[0-9]+}} = OpIMul %int {{%[0-9]+}} [[fisqr]] + for(int i = 0; i < N; ++i) + b[0].xs[i] = p.xs[i] * N; +} -- cgit v1.2.3