From 719772c01a8ee8afa81cded249d6a51e33e17d8d Mon Sep 17 00:00:00 2001 From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Date: Fri, 8 Aug 2025 13:07:00 -0700 Subject: Initial copy elision pass regression fix (#8126) when we have `GetElementPtr -> load -> GetElement` in our use-chain, the final `GetElement` may use the `load` as a `Index`, not a base. This is a non-issue with `getFieldExtract` since a field is a StructKey. We will still add this check to ensure no bugs down the line. --------- Co-authored-by: Harsh Aggarwal Co-authored-by: Claude Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- tests/bugs/gh-8121.slang | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 tests/bugs/gh-8121.slang (limited to 'tests/bugs') diff --git a/tests/bugs/gh-8121.slang b/tests/bugs/gh-8121.slang new file mode 100644 index 000000000..777e75b9e --- /dev/null +++ b/tests/bugs/gh-8121.slang @@ -0,0 +1,30 @@ +//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=CHECK):-cuda -compute -shaderobj + +//TEST_INPUT:ubuffer(data=[1 1 1 1], stride=4),name=inputBuffer +RWStructuredBuffer inputBuffer; + +//TEST_INPUT:ubuffer(data=[0 0 0 0 0], stride=4):out,name=outputBuffer +RWStructuredBuffer outputBuffer; + +void math(int data[2]) +{ + // This test is to ensure that we do not break our optimization-pass which optimizes the IR of + // `getElement(load(getElementPtr(...)), ...)` into `load(getElementPtr(getElementPtr(...), ...))`. + // + // This test triggers the bug given the IR: `store(outputBuffer[0], getElement(Array<>, load(getElementPtr(data,0))))`. + // `Array(5,6)` is not created as a local variable intentionally. We do this because we want to test the case + // where `Array<>` must be accessed as a value (`getElement`), not a pointer (`getElementPtr`). + // + // If this code fails, outputBuffer[0] will contain the value `1`. We expect `6` if the bug is fixed. + outputBuffer[0] = Array(5,6)[data[0]]; +} + +[shader("compute")] +[numthreads(1, 1, 1)] +void computeMain(int3 id: SV_DispatchThreadID) +{ + math(inputBuffer[0]); +} + +//CHECK: 6 +//CHECK-NEXT: 0 -- cgit v1.2.3