From 975c5db3f0a71bc93369a321318e7d3b43001ff5 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Fri, 17 Jul 2020 16:38:18 -0400 Subject: Disable specializing function calls if they have a struct param, that contains an array (#1448) * This code is disabled, it was part of the optimization `Specialize function calls involving array arguments. (#1389)` on github. It is disabled here because it causes a problem when a struct is passed to a function that contains a structured buffer *and* an array. It is specialized on the struct type, and so those types become parameters to the function. If the struct contains a structured buffer this is a problem on GLSL/VK based targets because currently structured buffers cannot be function parameters. The fix for now is to just disable this optimization. * Fix typo in name of test expected values. --- tests/bugs/specialize-function-array-args.slang.expected.txt | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 tests/bugs/specialize-function-array-args.slang.expected.txt (limited to 'tests/bugs/specialize-function-array-args.slang.expected.txt') diff --git a/tests/bugs/specialize-function-array-args.slang.expected.txt b/tests/bugs/specialize-function-array-args.slang.expected.txt new file mode 100644 index 000000000..93f39a7aa --- /dev/null +++ b/tests/bugs/specialize-function-array-args.slang.expected.txt @@ -0,0 +1,4 @@ +1 +1 +FFFFFFFF +FFFFFFFF -- cgit v1.2.3