From adaea0e993fd8db351b5dad92802e47ed6d0ec77 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 17 Aug 2022 23:08:34 -0700 Subject: Warning on lossy implicit casts. (#2367) * Warning on bool to float conversion. * Fix test cases. * Improve. * LanguageServer: don't show constant value for non constant variables. * Fix tests. * Fix warnings in tests. Co-authored-by: Yong He --- tests/bugs/bool-op.slang | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'tests/bugs/bool-op.slang') diff --git a/tests/bugs/bool-op.slang b/tests/bugs/bool-op.slang index 4d4b43221..911e23aa0 100644 --- a/tests/bugs/bool-op.slang +++ b/tests/bugs/bool-op.slang @@ -15,7 +15,7 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) uint uv = tid; int iv = int(tid); - bool2 bv2 = { tid & 1, tid > 10 }; + bool2 bv2 = { (tid & 1) != 0, tid > 10 }; float2 f2 = { float(tid), float(tid + 1) }; @@ -32,20 +32,20 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) r |= 0x0002; } - if (iv) + if (iv != 0) { r|= 0x0004; } - if (!iv) + if (!bool(iv)) { r|= 0x0008; - } - - if (uv) + } + + if (uv != 0) { r |= 0x0010; } - if (!uv) + if (!bool(uv)) { r |= 0x0020; } @@ -59,7 +59,7 @@ void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) r |= 0x0080; } - if (any(!f2)) + if (any(!bool2(f2))) { r |= 0x0100; } -- cgit v1.2.3