From fe77f076b46f45d6c89ab8592d0ff548bda223de Mon Sep 17 00:00:00 2001 From: Sai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com> Date: Tue, 4 Feb 2025 18:41:11 -0800 Subject: Fix non-square matrix derivatives (#6282) --- source/slang/slang-ir-autodiff-transpose.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'source') diff --git a/source/slang/slang-ir-autodiff-transpose.h b/source/slang/slang-ir-autodiff-transpose.h index a5ed5814c..5e96c4e0f 100644 --- a/source/slang/slang-ir-autodiff-transpose.h +++ b/source/slang/slang-ir-autodiff-transpose.h @@ -1812,8 +1812,8 @@ struct DiffTransposePass { List gradients; auto matrixType = as(fwdMakeMatrix->getDataType()); - auto row = as(matrixType->getRowCount()); auto colCount = matrixType->getColumnCount(); + auto colCountVal = as(matrixType->getColumnCount())->getValue(); IRType* rowVectorType = nullptr; for (UIndex ii = 0; ii < fwdMakeMatrix->getOperandCount(); ii++) { @@ -1828,9 +1828,8 @@ struct DiffTransposePass } else { - SLANG_RELEASE_ASSERT(row); - UInt rowIndex = ii / (UInt)row->getValue(); - UInt colIndex = ii % (UInt)row->getValue(); + UInt rowIndex = ii / (UInt)colCountVal; + UInt colIndex = ii % (UInt)colCountVal; if (!rowVectorType) rowVectorType = builder->getVectorType(matrixType->getElementType(), colCount); auto revRow = builder->emitElementExtract( -- cgit v1.2.3