From 9812963c52eb6312546f600804bb642a38dcfe64 Mon Sep 17 00:00:00 2001
From: Yong He <yonghe@outlook.com>
Date: Sun, 27 Jan 2019 00:08:17 -0800
Subject: Fix type legalization to correctly handle empty struct fields.

---
 source/slang/legalize-types.cpp | 41 +++++++++++++----------------------------
 1 file changed, 13 insertions(+), 28 deletions(-)

(limited to 'source')

diff --git a/source/slang/legalize-types.cpp b/source/slang/legalize-types.cpp
index 858dbd95c..30590c02d 100644
--- a/source/slang/legalize-types.cpp
+++ b/source/slang/legalize-types.cpp
@@ -785,17 +785,15 @@ LegalType legalizeTypeImpl(
         auto legalElementType = legalizeType(context,
             uniformBufferType->getElementType());
 
-        switch (legalElementType.flavor)
-        {
-        case LegalType::Flavor::simple:
-            return LegalType::simple(type);
-
-        default:
-            return createLegalUniformBufferType(
+        // Note that even when legalElementType.flavor == Simple
+        // we still need to create a new uniform buffer type
+        // from `legalElementType` instead of `type`
+        // because the `legalElementType` may still differ from `type`
+        // if `type` contains empty structs.
+        return createLegalUniformBufferType(
                 context,
                 uniformBufferType,
                 legalElementType);
-        }
 
     }
     else if (isResourceType(type))
@@ -898,27 +896,14 @@ LegalType legalizeTypeImpl(
             context,
             arrayType->getElementType());
 
-        switch (legalElementType.flavor)
-        {
-        case LegalType::Flavor::simple:
-            // Element type didn't need to be legalized, so
-            // we can just use this type as-is.
-            return LegalType::simple(type);
-
-        default:
-            {
-                ArrayLegalTypeWrapper wrapper;
-                wrapper.arrayType = arrayType;
-
-                return wrapLegalType(
-                    context,
-                    legalElementType,
-                    &wrapper,
-                    &wrapper);
-            }
-            break;
-        }
+        ArrayLegalTypeWrapper wrapper;
+        wrapper.arrayType = arrayType;
 
+        return wrapLegalType(
+            context,
+            legalElementType,
+            &wrapper,
+            &wrapper);
     }
 
     return LegalType::simple(type);
-- 
cgit v1.2.3