From b9dc21d362f65f22bc707bede733a9537b80460a Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Wed, 4 Jun 2025 10:35:52 -0700 Subject: Break down record replay to individual tests to avoid timeout (#7340) * Break down RecordReply to individual tests to avoid timeout In Debug build, RecordReplay unit-test was timing out. It was running six tests all in one unit-test, but this commit breaks it down to individual test so that each unit test can be done within the timeout limit. This issue has seen only in Debug build but it has been unnoticed because even when the test failed with test-server, it was still passing on its retry because the time-out applies only when using test-server. * Reduce the retry from 2 times to 1 time * Remove RecordReplay from expected failure --- source/slang-record-replay/record/record-manager.cpp | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) (limited to 'source') diff --git a/source/slang-record-replay/record/record-manager.cpp b/source/slang-record-replay/record/record-manager.cpp index 3be120c43..07f1d4e72 100644 --- a/source/slang-record-replay/record/record-manager.cpp +++ b/source/slang-record-replay/record/record-manager.cpp @@ -1,8 +1,10 @@ #include "record-manager.h" #include "../../core/slang-io.h" +#include "../../core/slang-platform.h" #include "../util/record-utility.h" +#include #include #include @@ -14,7 +16,19 @@ RecordManager::RecordManager(uint64_t globalSessionHandle) std::stringstream ss; ss << "gs-" << globalSessionHandle << "-t-" << std::this_thread::get_id() << ".cap"; - m_recordFileDirectory = Slang::Path::combine(m_recordFileDirectory, "slang-record"); + // Check for custom record directory from environment variable + Slang::StringBuilder customRecordDirBuilder; + if (SLANG_SUCCEEDED(Slang::PlatformUtil::getEnvironmentVariable( + Slang::UnownedStringSlice::fromLiteral("SLANG_RECORD_DIRECTORY"), + customRecordDirBuilder))) + { + m_recordFileDirectory = customRecordDirBuilder.toString(); + } + else + { + m_recordFileDirectory = Slang::Path::combine(m_recordFileDirectory, "slang-record"); + } + if (!Slang::File::exists(m_recordFileDirectory)) { if (!Slang::Path::createDirectoryRecursive(m_recordFileDirectory)) -- cgit v1.2.3