From 956ede9be7d7b798ce719a7ac6a3be3f472f6db7 Mon Sep 17 00:00:00 2001 From: Yong He Date: Fri, 5 Jun 2020 19:38:43 -0700 Subject: Filter lookup results from interfaces in `visitMemberExpr`. Fixes #1377 --- source/slang/slang-check-expr.cpp | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) (limited to 'source') diff --git a/source/slang/slang-check-expr.cpp b/source/slang/slang-check-expr.cpp index 307ec6316..7adda8c77 100644 --- a/source/slang/slang-check-expr.cpp +++ b/source/slang/slang-check-expr.cpp @@ -1826,10 +1826,38 @@ namespace Slang // expr->baseExpression = maybeOpenExistential(expr->baseExpression); - // TODO: Handle the case of an overloaded base expression + // Handle the case of an overloaded base expression // here, in case we can use the name of the member to // disambiguate which of the candidates is meant, or if // we can return an overloaded result. + if (auto overloadedExpr = as(expr->baseExpression)) + { + if (overloadedExpr->base) + { + // If a member (dynamic or static) lookup result contains both the actual definition + // and the interface definition obtained from inheritance, we want to filter out + // the interface definitions. + LookupResult filteredLookupResult; + for (auto lookupResult : overloadedExpr->lookupResult2) + { + bool shouldRemove = false; + if (lookupResult.declRef.getParent().as()) + shouldRemove = true; + if (!shouldRemove) + { + filteredLookupResult.items.add(lookupResult); + } + } + if (filteredLookupResult.items.getCount() == 1) + filteredLookupResult.item = filteredLookupResult.items.getFirst(); + expr->baseExpression = createLookupResultExpr( + expr->name, + filteredLookupResult, + overloadedExpr->base, + overloadedExpr->loc); + } + // TODO: handle other cases of OverloadedExpr that need filtering. + } auto & baseType = expr->baseExpression->type; -- cgit v1.2.3