From 4cf71197650ec1bf04c54783823a315cc7d477a5 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 25 Jun 2020 19:56:39 -0700 Subject: Add a TODO comment for generic interface requirement key --- source/slang/slang-lower-to-ir.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'source') diff --git a/source/slang/slang-lower-to-ir.cpp b/source/slang/slang-lower-to-ir.cpp index d18cd3bab..58f23b0c8 100644 --- a/source/slang/slang-lower-to-ir.cpp +++ b/source/slang/slang-lower-to-ir.cpp @@ -1001,6 +1001,10 @@ IRStructKey* getInterfaceRequirementKey( IRGenContext* context, Decl* requirementDecl) { + // TODO: this special case logic can be removed if we also clean up `doesGenericSignatureMatchRequirement` + // Currently `doesGenericSignatureMatchRequirement` will use the inner func decl as the key + // in AST WitnessTable. Therefore we need to match this behavior by always using the inner + // decl as the requirement key. if (auto genericDecl = as(requirementDecl)) return getInterfaceRequirementKey(context, genericDecl->inner); IRStructKey* requirementKey = nullptr; -- cgit v1.2.3