From 2d4cd997bcc95cb13552b540c376a8200f3766d5 Mon Sep 17 00:00:00 2001 From: Yong He Date: Fri, 21 Jul 2023 15:35:54 -0700 Subject: Don't error on disabled warnings when treatWarnAsErr. (#3013) Co-authored-by: Yong He --- source/compiler-core/slang-diagnostic-sink.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source') diff --git a/source/compiler-core/slang-diagnostic-sink.cpp b/source/compiler-core/slang-diagnostic-sink.cpp index 197e9bb64..a8d981545 100644 --- a/source/compiler-core/slang-diagnostic-sink.cpp +++ b/source/compiler-core/slang-diagnostic-sink.cpp @@ -592,7 +592,7 @@ Severity DiagnosticSink::getEffectiveMessageSeverity(DiagnosticInfo const& info) effectiveSeverity = *pSeverityOverride; } - if (isFlagSet(Flag::TreatWarningsAsErrors) && info.severity == Severity::Warning) + if (isFlagSet(Flag::TreatWarningsAsErrors) && effectiveSeverity == Severity::Warning) effectiveSeverity = Severity::Error; return effectiveSeverity; -- cgit v1.2.3