From 844d8d2212d11f3d28a55c81f234c99db2c26250 Mon Sep 17 00:00:00 2001
From: Darren Wihandi <65404740+fairywreath@users.noreply.github.com>
Date: Fri, 21 Mar 2025 11:52:28 -0400
Subject: Emit errors for missing returns on unsupported targets (#6633)

* initial wip

* more WIP

* preserve old lower behavior

* remove unnecessary includes

* add test

* add no target case in test

* fix broken test

---------

Co-authored-by: Ellie Hermaszewska <ellieh@nvidia.com>
---
 source/slang/slang-type-layout.cpp | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

(limited to 'source/slang/slang-type-layout.cpp')

diff --git a/source/slang/slang-type-layout.cpp b/source/slang/slang-type-layout.cpp
index e6729ca85..63bcd1ba2 100644
--- a/source/slang/slang-type-layout.cpp
+++ b/source/slang/slang-type-layout.cpp
@@ -2508,9 +2508,9 @@ bool isMetalTarget(TargetRequest* targetReq)
     }
 }
 
-bool isKhronosTarget(TargetRequest* targetReq)
+bool isKhronosTarget(CodeGenTarget target)
 {
-    switch (targetReq->getTarget())
+    switch (target)
     {
     default:
         return false;
@@ -2522,6 +2522,11 @@ bool isKhronosTarget(TargetRequest* targetReq)
     }
 }
 
+bool isKhronosTarget(TargetRequest* targetReq)
+{
+    return isKhronosTarget(targetReq->getTarget());
+}
+
 bool isCPUTarget(TargetRequest* targetReq)
 {
     return ArtifactDescUtil::isCpuLikeTarget(
@@ -2541,9 +2546,9 @@ bool isCUDATarget(TargetRequest* targetReq)
     }
 }
 
-bool isWGPUTarget(TargetRequest* targetReq)
+bool isWGPUTarget(CodeGenTarget target)
 {
-    switch (targetReq->getTarget())
+    switch (target)
     {
     default:
         return false;
@@ -2555,6 +2560,11 @@ bool isWGPUTarget(TargetRequest* targetReq)
     }
 }
 
+bool isWGPUTarget(TargetRequest* targetReq)
+{
+    return isWGPUTarget(targetReq->getTarget());
+}
+
 SourceLanguage getIntermediateSourceLanguageForTarget(TargetProgram* targetProgram)
 {
     // If we are emitting directly, there is no intermediate source language
-- 
cgit v1.2.3