From d3331fba6eaab44646010b556106da38925d43e0 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Thu, 6 Feb 2020 14:31:09 -0500 Subject: Literal handling improvements (#1202) * WIP: 64 literal diagnostic and truncation. * Improve how integer truncation is handled/supported. Added literal-int64.slang test. Set a suffix on all literals. Fixed problem on C++ based targets where l suffix was not the same as int() cast. So on C++ derived emitters, int() is used instead of l suffix to have same behavior across targets. * Add literal diagnostic testing. * Allow lexer to lex - in front of literals. * Fix lexing and converting int literal with -. * Too large small values of floats become inf. Handling writing inf types out on different targets. Add function to deterimine if a float literals kind. * Roll back the support of lexer lexing negative literals. * Fixed tests broken because of diagnostics numbers. Improved _isFinite * Fix compilation on linux. * Fix problem with abs on linux - use Math::Abs. * Fix typo. * * Improve warnings for float literals zeroed * Improved 64 bit type documentation * Handle half * Improved comments * Fixed tests broken * Use capital letters for suffixes. * Make default behavior on outputting a int literal that is an 'int32_t' is cast (not suffix) to avoid platform inconsistencies. Improve documentation for 64 bit types. Make tests cover material in docs. * Fixed tests. * Rename FloatKind::Normal -> Finite * Fix half zero check. --- source/slang/slang-stdlib.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'source/slang/slang-stdlib.cpp') diff --git a/source/slang/slang-stdlib.cpp b/source/slang/slang-stdlib.cpp index 26a7dbb65..551a911c8 100644 --- a/source/slang/slang-stdlib.cpp +++ b/source/slang/slang-stdlib.cpp @@ -90,7 +90,7 @@ namespace Slang // Here we declare the table of all our builtin types, so that we can generate all the relevant declarations. // - struct BaseTypeInfo + struct BaseTypeConversionInfo { char const* name; BaseType tag; @@ -98,7 +98,7 @@ namespace Slang BaseTypeConversionKind conversionKind; BaseTypeConversionRank conversionRank; }; - static const BaseTypeInfo kBaseTypes[] = { + static const BaseTypeConversionInfo kBaseTypes[] = { // TODO: `void` really shouldn't be in the `BaseType` enumeration, since it behaves so differently across the board { "void", BaseType::Void, 0, kBaseTypeConversionKind_Error, kBaseTypeConversionRank_Error}, @@ -121,8 +121,8 @@ namespace Slang // Given two base types, we need to be able to compute the cost of converting between them. ConversionCost getBaseTypeConversionCost( - BaseTypeInfo const& toInfo, - BaseTypeInfo const& fromInfo) + BaseTypeConversionInfo const& toInfo, + BaseTypeConversionInfo const& fromInfo) { if(toInfo.conversionKind == fromInfo.conversionKind && toInfo.conversionRank == fromInfo.conversionRank) -- cgit v1.2.3