From c90c6ab750ab05dd6d337e4f857958b8f3d00153 Mon Sep 17 00:00:00 2001 From: Yong He Date: Mon, 13 Jun 2022 12:20:35 -0700 Subject: Language Server improvements. (#2269) * Language Server improvements. - Improve parser robustness around `attribute_syntax`. - Exclude instance members in a static query. - Coloring accessors - Improved signature help cursor range check. * Add expected test result. * Language server: support configuring predefined macros. * Fix constructor highlighting. * Improving performance by supporting incremental text change notifications. * Fix UTF16 positions and highlighting of constructor calls. * Add completion suggestions for HLSL semantics. * Fix tests. * Fix: don't skip static variables in a static query. * Include literal init expr value in hover text. * Fix scenarios where completion failed to trigger. * Fixing language server protocol field initializations. Co-authored-by: Yong He --- source/slang/slang-serialize-source-loc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/slang/slang-serialize-source-loc.cpp') diff --git a/source/slang/slang-serialize-source-loc.cpp b/source/slang/slang-serialize-source-loc.cpp index 331ca96ae..35473a1be 100644 --- a/source/slang/slang-serialize-source-loc.cpp +++ b/source/slang/slang-serialize-source-loc.cpp @@ -286,13 +286,13 @@ SlangResult SerialSourceLocReader::read(const SerialSourceLocData* serialData, S const auto& lineInfo = lineInfos[lineInfoIndex]; const uint32_t offset = lineInfo.m_lineStartOffset; - SLANG_ASSERT(offset > 0); const int finishIndex = int(lineInfo.m_lineIndex); SLANG_ASSERT(finishIndex < numLines); for (; lineIndex < finishIndex; ++lineIndex) { + SLANG_ASSERT(offset > 0); lineBreakOffsets[lineIndex] = offset - 1; } lineBreakOffsets[lineIndex] = offset; -- cgit v1.2.3