From e050035e0b7d3f257a46bc1cb644163026cb1b23 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 25 Mar 2021 09:41:53 -0700 Subject: Improve Vulkan shader-objects implementation. (#1765) * Improve Vulkan shader-objects implementation. 1. Null bindings no longer crashes. 2. No longer copies push constants to staging CPU buffer before setting it into command buffer. The entry-point shader object now directly sets it into command buffer upon `bindObject` call. * Update comments * Fix * Re-enable 3 tests. Improved vulkan implementation so that each shader object is responsible for creating descriptor sets on-demand. Fixed slang reflection to correctly report `ParameterBlock` binding. * Fix gcc compile error. --- source/slang/slang-reflection-api.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'source/slang/slang-reflection-api.cpp') diff --git a/source/slang/slang-reflection-api.cpp b/source/slang/slang-reflection-api.cpp index cd141a622..2031b4a0f 100644 --- a/source/slang/slang-reflection-api.cpp +++ b/source/slang/slang-reflection-api.cpp @@ -1152,6 +1152,10 @@ namespace Slang { return SLANG_BINDING_TYPE_SAMPLER; } + else if (as(type)) + { + return SLANG_BINDING_TYPE_PARAMETER_BLOCK; + } else { return SLANG_BINDING_TYPE_UNKNOWN; -- cgit v1.2.3