From 7b447bdad29c828b49ba63cefacc677bd7c58b28 Mon Sep 17 00:00:00 2001
From: jsmall-nvidia <jsmall@nvidia.com>
Date: Fri, 9 Jul 2021 16:29:23 -0400
Subject: Make Scope non ref counted (#1904)

* Add debug symbols for release build.

* Hack to try and capture failing compilation.

* Typo fix for capture hack.

* Specify return type on lambdas.

* Added const.

* Try breakpoint.

* Up count

* Let's capture everything so we can valgrind.

* Disable always writing repros.

* Make Scope non RefCounted.

* Fix issue with not serializing Scope.

* More comments around changes to Scope.
Remove Scope* from serialization.

* Remove code used for testing original issue.
---
 source/slang/slang-lookup.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'source/slang/slang-lookup.cpp')

diff --git a/source/slang/slang-lookup.cpp b/source/slang/slang-lookup.cpp
index f41d8ff3b..20670e7b3 100644
--- a/source/slang/slang-lookup.cpp
+++ b/source/slang/slang-lookup.cpp
@@ -755,6 +755,7 @@ static void _lookUpInScopes(
     auto thisParameterMode = LookupResultItem::Breadcrumb::ThisParameterMode::Default;
 
     auto scope      = request.scope;
+
     auto endScope   = request.endScope;
     for (;scope != endScope; scope = scope->parent)
     {
@@ -918,7 +919,7 @@ LookupResult lookUp(
     ASTBuilder*         astBuilder, 
     SemanticsVisitor*   semantics,
     Name*               name,
-    RefPtr<Scope>       scope,
+    Scope*              scope,
     LookupMask          mask)
 {
     LookupRequest request;
-- 
cgit v1.2.3