From 1b01ff909afa1eb6700c0dc947e679b9c3890880 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Tue, 27 Jun 2023 11:28:14 -0400 Subject: Pointer layout support (#2930) * WIP looking at reflection with pointers. * Added GetPointerLayout. * Initial test via reflection with layout of ptr type. * WIP handles ptrs to types that have layout that hasn't been completed. * Move tests to ptr. * WIP try to take into account lowering correctly between AggTypeDecl and Type, but doesn't quite work. * WIP a different path to handling recursive lowering problem with Ptr. * Fix issues with reflection output. * Small tidy. * Fix for infinite recursion issue. * Lower IRPointerTypeLayout * Working with generics. Has a hack to work around Layout around Ptr in IR. The reflection around the generic - the name isn't much use, it should probably have the generic parameters, but that would require getName to do something more sophisticated. * Fix issue around calling finishOuterGenerics to early. * Remove feature/ptr test. * Fix type legalization being an infinite loop with Ptr self referencing. * Disable the pointer self reference test because produces an infintie loop on emit. * Fixed comment based on review. * Fix for issue with emit and pointers causing infinite recursion. --- source/slang/slang-ir.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'source/slang/slang-ir.cpp') diff --git a/source/slang/slang-ir.cpp b/source/slang/slang-ir.cpp index cac49f5f7..fb121d245 100644 --- a/source/slang/slang-ir.cpp +++ b/source/slang/slang-ir.cpp @@ -967,6 +967,18 @@ namespace Slang ioOperands.add(m_elementTypeLayout); } + // + // IRPointerTypeLayout + // + + void IRPointerTypeLayout::Builder::addOperandsImpl(List& ioOperands) + { + SLANG_UNUSED(ioOperands); + // TODO(JS): For now we don't store the value types layout to avoid + // infinite recursion. + //ioOperands.add(m_valueTypeLayout); + } + // // IRStreamOutputTypeLayout // -- cgit v1.2.3