From a3ac6e71cbc922b7c941c45f23ee18a9fc274d1f Mon Sep 17 00:00:00 2001
From: Yong He <yonghe@outlook.com>
Date: Wed, 11 Jan 2023 15:33:28 -0800
Subject: Make backward differentiation work with generics. (#2586)

* Make backward differentiation work with generics.

* Fix.

* Another fix.

* More fix.

Co-authored-by: Yong He <yhe@nvidia.com>
---
 source/slang/slang-ir-validate.cpp | 43 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)

(limited to 'source/slang/slang-ir-validate.cpp')

diff --git a/source/slang/slang-ir-validate.cpp b/source/slang/slang-ir-validate.cpp
index 46817e212..a49eda322 100644
--- a/source/slang/slang-ir-validate.cpp
+++ b/source/slang/slang-ir-validate.cpp
@@ -29,7 +29,14 @@ namespace Slang
     {
         if (!condition)
         {
-            context->getSink()->diagnose(inst, Diagnostics::irValidationFailed, message);
+            if (context)
+            {
+                context->getSink()->diagnose(inst, Diagnostics::irValidationFailed, message);
+            }
+            else
+            {
+                SLANG_ASSERT_FAILURE("IR validation failed");
+            }
         }
     }
 
@@ -143,7 +150,10 @@ namespace Slang
                     // If `operandValue` precedes `inst`, then we should
                     // have already seen it, because we scan parent instructions
                     // in order.
-                    validate(context, context->seenInsts.Contains(operandValue),    inst, "def must come before use in same block");
+                    if (context)
+                    {
+                        validate(context, context->seenInsts.Contains(operandValue),    inst, "def must come before use in same block");
+                    }
                     return;
                 }
 
@@ -196,6 +206,34 @@ namespace Slang
         }
     }
 
+    static thread_local bool _enableIRValidationAtInsert = false;
+    void disableIRValidationAtInsert()
+    {
+        _enableIRValidationAtInsert = false;
+    }
+    void enableIRValidationAtInsert()
+    {
+        _enableIRValidationAtInsert = true;
+    }
+    void validateIRInstOperands(IRInst* inst)
+    {
+        if (!_enableIRValidationAtInsert)
+            return;
+        switch (inst->getOp())
+        {
+        case kIROp_loop:
+        case kIROp_ifElse:
+        case kIROp_unconditionalBranch:
+        case kIROp_conditionalBranch:
+        case kIROp_Switch:
+            return;
+        default:
+            break;
+        }
+        
+        validateIRInstOperands(nullptr, inst);
+    }
+
     void validateCodeBody(IRValidateContext* context, IRGlobalValueWithCode* code)
     {
         HashSet<IRBlock*> blocks;
@@ -296,4 +334,5 @@ namespace Slang
         auto sink = codeGenContext->getSink();
         validateIRModule(module, sink);
     }
+
 }
-- 
cgit v1.2.3