From 10b2038a8e71eb4a0e41cff38bc71e36dc0003aa Mon Sep 17 00:00:00 2001 From: Ellie Hermaszewska Date: Tue, 8 Aug 2023 06:01:02 +0800 Subject: Diagnostic improvements for direct spirv (#3053) * Fail on an unhandled spv operand * Diagnose on emitting a function with no definition or intrinsic * clearer error message * Add assert * Add assert * remove unused assert * Disagnostic on snippet parsing failure * Mention unimplemented instruction in error message * mention unhandled local instruction for spirv in error message * Allow specifying dump options in dumpIRToString --------- Co-authored-by: Yong He --- source/slang/slang-ir-util.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'source/slang/slang-ir-util.cpp') diff --git a/source/slang/slang-ir-util.cpp b/source/slang/slang-ir-util.cpp index 07aaa127f..41ac19ee9 100644 --- a/source/slang/slang-ir-util.cpp +++ b/source/slang/slang-ir-util.cpp @@ -258,14 +258,10 @@ void moveInstChildren(IRInst* dest, IRInst* src) } } -String dumpIRToString(IRInst* root) +String dumpIRToString(IRInst* root, IRDumpOptions options) { StringBuilder sb; StringWriter writer(&sb, Slang::WriterFlag::AutoFlush); - IRDumpOptions options = {}; -#if 1 - options.flags = IRDumpOptions::Flag::DumpDebugIds; -#endif dumpIR(root, options, nullptr, &writer); return sb.toString(); } -- cgit v1.2.3