From 92ae4949fe1af28ef31331fd4116c8111c057420 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Fri, 2 Dec 2022 09:29:38 -0500 Subject: Inline functions with string param/return for GPU targets (#2544) * #include an absolute path didn't work - because paths were taken to always be relative. * WIP inlining of functions that take or return string related types on GPU targets. * Small fixes. * Added a test. * Add checking for any getStringHash insts are valid. * Support getStringHash on CUDA. * Tweak diagnostic. --- source/slang/slang-ir-string-hash.cpp | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) (limited to 'source/slang/slang-ir-string-hash.cpp') diff --git a/source/slang/slang-ir-string-hash.cpp b/source/slang/slang-ir-string-hash.cpp index 8ff0ec756..8bccb97db 100644 --- a/source/slang/slang-ir-string-hash.cpp +++ b/source/slang/slang-ir-string-hash.cpp @@ -18,6 +18,11 @@ static void _findGetStringHashRec(IRInst* inst, List& outInsts } } +void findGetStringHashInsts(IRModule* module, List& outInsts) +{ + _findGetStringHashRec(module->getModuleInst(), outInsts); +} + void findGlobalHashedStringLiterals(IRModule* module, StringSlicePool& pool) { IRModuleInst* moduleInst = module->getModuleInst(); @@ -78,4 +83,27 @@ void addGlobalHashedStringLiterals(const StringSlicePool& pool, SharedIRBuilder& builder.addKeepAliveDecoration(globalHashedInst); } +Result checkGetStringHashInsts(IRModule* module, DiagnosticSink* sink) +{ + // Check all getStringHash are all on string literals + List insts; + findGetStringHashInsts(module, insts); + + for (auto inst : insts) + { + if (inst->getStringLit() == nullptr) + { + if (sink) + { + sink->diagnose(inst, Diagnostics::getStringHashMustBeOnStringLiteral); + } + + // Doesn't access a string literal + return SLANG_FAIL; + } + } + + return SLANG_OK; +} + } -- cgit v1.2.3