From abc100f81d4b22229105f9ed569a7efafc653a3a Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 29 Jun 2022 13:38:50 -0700 Subject: Native call marshalling for ComPtr parameters and return values. (#2305) Co-authored-by: Yong He --- source/slang/slang-ir-marshal-native-call.cpp | 48 ++++++++++++++++++++++++--- 1 file changed, 43 insertions(+), 5 deletions(-) (limited to 'source/slang/slang-ir-marshal-native-call.cpp') diff --git a/source/slang/slang-ir-marshal-native-call.cpp b/source/slang/slang-ir-marshal-native-call.cpp index b8e2edb2f..8e342cb26 100644 --- a/source/slang/slang-ir-marshal-native-call.cpp +++ b/source/slang/slang-ir-marshal-native-call.cpp @@ -12,6 +12,10 @@ namespace Slang { case kIROp_StringType: return builder.getNativeStringType(); + case kIROp_InterfaceType: + return builder.getNativePtrType(type); + case kIROp_ComPtrType: + return builder.getNativePtrType((IRType*)as(type)->getOperand(0)); default: return type; } @@ -30,10 +34,14 @@ namespace Slang IRType* returnType = declaredFuncType->getResultType(); if (auto resultType = as(declaredFuncType->getResultType())) { - nativeParamTypes.add(builder.getPtrType(resultType->getValueType())); + auto nativeResultType = getNativeType(builder, resultType->getValueType()); + nativeParamTypes.add(builder.getPtrType(nativeResultType)); returnType = resultType->getErrorType(); } - getNativeType(builder, declaredFuncType->getResultType()); + else + { + returnType = getNativeType(builder, returnType); + } auto funcType = builder.getFuncType( nativeParamTypes.getCount(), (IRType**)nativeParamTypes.getBuffer(), returnType); @@ -43,9 +51,18 @@ namespace Slang void NativeCallMarshallingContext::marshalRefManagedValueToNativeValue( IRBuilder& builder, IRInst* originalArg, List& args) { - SLANG_UNUSED(builder); - SLANG_UNUSED(originalArg); - args.add(originalArg); + auto ptrTypeBase = as(originalArg->getDataType()); + SLANG_RELEASE_ASSERT(ptrTypeBase); + switch (ptrTypeBase->getValueType()->getOp()) + { + case kIROp_InterfaceType: + case kIROp_ComPtrType: + args.add(builder.emitGetManagedPtrWriteRef(originalArg)); + break; + default: + args.add(originalArg); + break; + } } void NativeCallMarshallingContext::marshalManagedValueToNativeValue( @@ -63,6 +80,12 @@ namespace Slang args.add(nativeStr); } break; + case kIROp_InterfaceType: + { + auto nativePtr = builder.emitGetNativePtr(originalArg); + args.add(nativePtr); + } + break; default: args.add(originalArg); break; @@ -79,6 +102,21 @@ namespace Slang return builder.emitMakeString(nativeVal); } break; + case kIROp_NativePtrType: + { + SLANG_RELEASE_ASSERT(nativeVal->getDataType()->getOperand(0)->getOp() == kIROp_InterfaceType); + auto comPtrVar = builder.emitVar(builder.getComPtrType((IRType*)nativeVal->getDataType()->getOperand(0))); + builder.emitManagedPtrAttach(comPtrVar, nativeVal); + return builder.emitLoad(comPtrVar); + } + break; + case kIROp_InterfaceType: + { + auto comPtrVar = builder.emitVar(nativeVal->getDataType()); + builder.emitManagedPtrAttach(comPtrVar, nativeVal); + return builder.emitLoad(comPtrVar); + } + break; default: return nativeVal; break; -- cgit v1.2.3