From a3ac6e71cbc922b7c941c45f23ee18a9fc274d1f Mon Sep 17 00:00:00 2001
From: Yong He <yonghe@outlook.com>
Date: Wed, 11 Jan 2023 15:33:28 -0800
Subject: Make backward differentiation work with generics. (#2586)

* Make backward differentiation work with generics.

* Fix.

* Another fix.

* More fix.

Co-authored-by: Yong He <yhe@nvidia.com>
---
 source/slang/slang-ir-lower-generic-function.cpp | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

(limited to 'source/slang/slang-ir-lower-generic-function.cpp')

diff --git a/source/slang/slang-ir-lower-generic-function.cpp b/source/slang/slang-ir-lower-generic-function.cpp
index 806ea8826..6f412d579 100644
--- a/source/slang/slang-ir-lower-generic-function.cpp
+++ b/source/slang/slang-ir-lower-generic-function.cpp
@@ -48,9 +48,12 @@ namespace Slang
             IRCloneEnv cloneEnv;
             IRBuilder builder(sharedContext->sharedBuilderStorage);
             builder.setInsertBefore(genericParent);
+            // Do not clone func type (which would break IR def-use rules if we do it here)
+            // This is OK since we will lower the type immediately after the clone.
+            cloneEnv.mapOldValToNew[func->getFullType()] = builder.getTypeKind();
             auto loweredFunc = cast<IRFunc>(cloneInstAndOperands(&cloneEnv, &builder, func));
             auto loweredGenericType =
-                lowerGenericFuncType(&builder, cast<IRGeneric>(genericParent->getFullType()));
+                lowerGenericFuncType(&builder, genericParent, cast<IRFuncType>(func->getFullType()));
             SLANG_ASSERT(loweredGenericType);
             loweredFunc->setFullType(loweredGenericType);
             List<IRInst*> clonedParams;
@@ -90,7 +93,7 @@ namespace Slang
             return loweredFunc;
         }
 
-        IRType* lowerGenericFuncType(IRBuilder* builder, IRGeneric* genericVal)
+        IRType* lowerGenericFuncType(IRBuilder* builder, IRGeneric* genericVal, IRFuncType* funcType)
         {
             ShortList<IRInst*> genericParamTypes;
             Dictionary<IRInst*, IRInst*> typeMapping;
@@ -107,7 +110,7 @@ namespace Slang
 
             auto innerType = (IRFuncType*)lowerFuncType(
                 builder,
-                cast<IRFuncType>(findGenericReturnVal(genericVal)),
+                funcType,
                 typeMapping,
                 genericParamTypes.getArrayView().arrayView);
 
@@ -182,7 +185,10 @@ namespace Slang
                     }
                     else if (auto genericFuncType = as<IRGeneric>(requirementVal))
                     {
-                        loweredVal = lowerGenericFuncType(&builder, genericFuncType);
+                        loweredVal = lowerGenericFuncType(
+                            &builder,
+                            genericFuncType,
+                            cast<IRFuncType>(findGenericReturnVal(genericFuncType)));
                     }
                     else if (requirementVal->getOp() == kIROp_AssociatedType)
                     {
-- 
cgit v1.2.3