From b36659eca38be716bee43c01c6584bda5f91166a Mon Sep 17 00:00:00 2001 From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Date: Tue, 26 Aug 2025 10:48:49 -0700 Subject: Fix `shouldEmitSPIRVDirectly` (#8019) Fixes: #8018 Changes: * Do not emit true for `shouldEmitSPIRVDirectly` with a GLSL target --- source/slang/slang-ir-lower-buffer-element-type.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'source/slang/slang-ir-lower-buffer-element-type.cpp') diff --git a/source/slang/slang-ir-lower-buffer-element-type.cpp b/source/slang/slang-ir-lower-buffer-element-type.cpp index 2f40c6cf9..056ee6244 100644 --- a/source/slang/slang-ir-lower-buffer-element-type.cpp +++ b/source/slang/slang-ir-lower-buffer-element-type.cpp @@ -666,7 +666,10 @@ struct LoweredElementTypeContext // For spirv backend, we always want to lower all array types, even if the element type // comes out the same. This is because different layout rules may have different array // stride requirements. - if (!target->shouldEmitSPIRVDirectly()) + // + // Additionally, `buffer` blocks do not work correctly unless lowered when targeting + // GLSL. + if (!isKhronosTarget(target->getTargetReq())) { // For non-spirv target, we skip lowering this type if all field types are // unchanged. -- cgit v1.2.3