From 19867ffca6dca7995c799354081219c9e76f13d1 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 20 Feb 2025 14:48:51 -0800 Subject: Simplify implicit cast ctors for vector & matrix. (#6408) * Simplify implicit cast ctors for vector & matrix. * Fix formatting. * Fix tests. * Fix Falcor test. * Mark __builtin_cast as internal. --- source/slang/slang-ir-constexpr.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'source/slang/slang-ir-constexpr.cpp') diff --git a/source/slang/slang-ir-constexpr.cpp b/source/slang/slang-ir-constexpr.cpp index ff6d64319..620c65d4e 100644 --- a/source/slang/slang-ir-constexpr.cpp +++ b/source/slang/slang-ir-constexpr.cpp @@ -116,6 +116,7 @@ bool opCanBeConstExpr(IROp op) case kIROp_PtrCast: case kIROp_Reinterpret: case kIROp_BitCast: + case kIROp_BuiltinCast: case kIROp_MakeTuple: case kIROp_MakeDifferentialPair: case kIROp_MakeExistential: @@ -178,7 +179,13 @@ bool opCanBeConstExprByBackwardPass(IRInst* value) { if (value->getOp() == kIROp_Param) return isLoopPhi(as(value)); - return opCanBeConstExpr(value->getOp()); + if (opCanBeConstExpr(value->getOp())) + return true; + if (auto callInst = as(value)) + { + return !callInst->mightHaveSideEffects(); + } + return false; } void markConstExpr(PropagateConstExprContext* context, IRInst* value) -- cgit v1.2.3