From 945409c4c6871c18aad24086c594cc66b5913733 Mon Sep 17 00:00:00 2001
From: Sai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com>
Date: Thu, 17 Aug 2023 14:45:13 -0400
Subject: Initial support for differentiating existential types (#3111)

* Merge

* WIP: Complete auto-diff logic for existential types

* Revert "Add compiler option for generating representative hash"

This reverts commit 13b09ef4621e73844c96d64d9c111a8ed0d45aae.

* More fixes for fwd-mode AD on existential types

* Add anyValueSize inference pass

* Fix checking of `Differential.Differential==Differential`

* In-progress: infer any-value-size for existential types

* Existentials now work in forward-mode

* Overhaul handling of existential AD types. Fwd-mode works, reverse-mode requires front-end changes

* Reverse-mode now works on existentials

* Cleanup

* Remove diff rules for create existential object for now

* Revert treat-as-differentiable changes

* Fixes

* More fixes

* Cleanup

* more cleanup

* signed/unsigned

* Revert "Cleanup"

This reverts commit e4f7d71f07bb207736f90708961eeecd09a1b652.

* Cleanup (again)

* Remove public/export/keep-alive on null differential after AD pass

* Minor fix

* Update dictionary accessors

* Keep export decoration

* More fixes + Support for `kIROp_PackAnyValue`

* Merge upstream

* Update expected-failure.txt
---
 source/slang/slang-ir-clone.cpp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

(limited to 'source/slang/slang-ir-clone.cpp')

diff --git a/source/slang/slang-ir-clone.cpp b/source/slang/slang-ir-clone.cpp
index 9258e511f..43b60d6ed 100644
--- a/source/slang/slang-ir-clone.cpp
+++ b/source/slang/slang-ir-clone.cpp
@@ -267,7 +267,15 @@ IRInst* cloneInst(
         env, builder, oldInst);
 
     env->mapOldValToNew.add(oldInst, newInst);
-
+    
+    // For hoistable insts, its possible that the cloned inst is the same
+    // as the original inst.
+    // Skip the decoration/children cloning in that case (which will end up 
+    // in an infinite loop)
+    // 
+    if (newInst == oldInst)
+        return newInst;
+    
     cloneInstDecorationsAndChildren(
         env, builder->getModule(), oldInst, newInst);
 
-- 
cgit v1.2.3