From 47715e625337d489f3c0131bbc2b849378b48a5a Mon Sep 17 00:00:00 2001 From: Yong He Date: Mon, 20 Feb 2023 14:42:50 -0800 Subject: Miscellaneous backward autodiff fixes. (#2665) * Fix differentiable type registration * Fix use of non-differentiable return value in a differentiable func. * Fix use of primal inst that does not dominate the diff block. * Fix primal inst hoisting, and add missing type legalization logic. * Make `detach` defined on all differentiable T. --------- Co-authored-by: Yong He --- source/slang/slang-ir-check-differentiability.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'source/slang/slang-ir-check-differentiability.cpp') diff --git a/source/slang/slang-ir-check-differentiability.cpp b/source/slang/slang-ir-check-differentiability.cpp index c750b2d3d..1ee94e67e 100644 --- a/source/slang/slang-ir-check-differentiability.cpp +++ b/source/slang/slang-ir-check-differentiability.cpp @@ -353,6 +353,17 @@ public: auto loop = as(block->getTerminator()); if (!loop) continue; + bool hasBackEdge = false; + for (auto use = loop->getTargetBlock()->firstUse; use; use = use->nextUse) + { + if (use->getUser() != loop) + { + hasBackEdge = true; + break; + } + } + if (!hasBackEdge) + continue; if (loop->findDecoration() || loop->findDecoration()) { // We are good. -- cgit v1.2.3