From ab284ca61d0c4c29ac7331b99a98f95bb3ad44e5 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 25 May 2023 23:39:30 -0700 Subject: Fix bug in legalizeFuncType that leads to invalid IR. (#2902) * Fix bug in legalizeFuncType that leads to invalid IR. * Diagnose on functions that never returns when differentiate it. --------- Co-authored-by: Yong He --- source/slang/slang-ir-autodiff-rev.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'source/slang/slang-ir-autodiff-rev.cpp') diff --git a/source/slang/slang-ir-autodiff-rev.cpp b/source/slang/slang-ir-autodiff-rev.cpp index 70c43cdcb..3f0036b06 100644 --- a/source/slang/slang-ir-autodiff-rev.cpp +++ b/source/slang/slang-ir-autodiff-rev.cpp @@ -537,10 +537,17 @@ namespace Slang DifferentiableTypeConformanceContext diffTypeContext(autoDiffSharedContext); diffTypeContext.setFunc(func); - if (!isSingleReturnFunc(func)) + auto returnCount = getReturnCount(func); + if (returnCount > 1) { convertFuncToSingleReturnForm(func->getModule(), func); } + else if (returnCount == 0) + { + // The function is ill-formed and never returns (such as having an infinite loop), + // we can't possibly reverse-differentiate such functions, so we will diagnose it here. + getSink()->diagnose(func->sourceLoc, Diagnostics::functionNeverReturnsFatal, func); + } eliminateContinueBlocksInFunc(func->getModule(), func); -- cgit v1.2.3