From ec42c4a20facbcae441cd172bfd607614e761907 Mon Sep 17 00:00:00 2001 From: Julius Ikkala Date: Wed, 10 Sep 2025 21:41:07 +0300 Subject: Fix pointers and C-like layout in varying parameters (#8425) Closes #8409, but ended up being more about fixing another bug. While the issue itself seems to only be a simple typo fix (see second commit in this PR), I found out during writing a test that pointers never got correct locations regardless of layout. Their locations were always assigned to zero due to lacking a resource usage entry in `TypeLayout`. They were also missing the `Flat` decoration, so I went ahead and added that too. I can split this up into two separate PRs if that's preferred; both aspects just share a test right now and fix a similar-looking issue in the resulting SPIR-V. --- source/slang/slang-emit-spirv.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'source/slang/slang-emit-spirv.cpp') diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp index e8bcad1c1..f82bf24c1 100644 --- a/source/slang/slang-emit-spirv.cpp +++ b/source/slang/slang-emit-spirv.cpp @@ -3020,7 +3020,7 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex bool anyModifiers = (var->findDecoration() != nullptr); // If the user didn't explicitly qualify a varying - // with integer type, then we need to explicitly + // with integer or pointer type, then we need to explicitly // add the `flat` modifier for GLSL. if (!anyModifiers) { @@ -3030,7 +3030,8 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex layout->usesResourceKind(LayoutResourceKind::VaryingInput)) { const auto ptrType = as(var->getDataType()); - if (ptrType && isIntegralScalarOrCompositeType(ptrType->getValueType())) + if (ptrType && (isIntegralScalarOrCompositeType(ptrType->getValueType()) || + as(ptrType->getValueType()))) emitOpDecorate( getSection(SpvLogicalSectionID::Annotations), nullptr, -- cgit v1.2.3