From d50c3f34a2eda5bf5e278c78d32cc9923fd83b82 Mon Sep 17 00:00:00 2001 From: aidanfnv Date: Tue, 1 Jul 2025 00:41:52 -0700 Subject: Add arguments for controlling floating point denormal mode (#7461) * Implement -fp-denorm-mode slangc arg * Split fp-denorm-mode into 3 args for fp16/32/64 * Remove redundant option categories * Use emitInst for multiple of the same OpExecutionMode * Fix formatting * Remove -denorm any * Re-add option categories * emitinst for ftz * Use enums for type text * Remove extra categories again * Add tests for denorm mode * Move denorm mode to post linking * format code (#8) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> * regenerate command line reference (#9) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> * Clean up tests * Fix option text * format code (#10) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> * Add tests for "any" mode * Return "any" enum if option not set * Simplify emission logic * Add support for generic entrypoints * Move denorm modes to end of CompilerOptionName enum * format code (#11) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> * Move new enum members to before CountOf * Add not checks to tests, fix generic test, add functionality tests * Rename denorm to fpDenormal * Clean up functional test * Rename denorm test dir * Fix formatting, regenerate cmdline ref * Fold simple tests into functional tests, add more dxil checks * Remove no-op DX tests, make tests more consistent * Disable VK functionality tests that will fail on the CI configs * Fix formatting * Add comments to disabled tests explaining why --------- Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- source/slang/slang-emit-spirv.cpp | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) (limited to 'source/slang/slang-emit-spirv.cpp') diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp index dc5352041..52e8e3d65 100644 --- a/source/slang/slang-emit-spirv.cpp +++ b/source/slang/slang-emit-spirv.cpp @@ -5121,6 +5121,42 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex } } break; + case kIROp_FpDenormalPreserveDecoration: + { + auto fpDenormalDecor = cast(decoration); + auto width = int32_t(getIntVal(fpDenormalDecor->getWidth())); + ensureExtensionDeclaration(UnownedStringSlice("SPV_KHR_float_controls")); + requireSPIRVCapability(SpvCapabilityDenormPreserve); + // emitInst is used instead of requireSPIRVExecutionMode because + // we need to be able to emit the same execution mode with different + // operands for different widths + emitInst( + getSection(SpvLogicalSectionID::ExecutionModes), + decoration, + SpvOpExecutionMode, + dstID, + SpvExecutionModeDenormPreserve, + SpvLiteralInteger::from32(width)); + } + break; + case kIROp_FpDenormalFlushToZeroDecoration: + { + auto fpDenormalDecor = cast(decoration); + auto width = int32_t(getIntVal(fpDenormalDecor->getWidth())); + ensureExtensionDeclaration(UnownedStringSlice("SPV_KHR_float_controls")); + requireSPIRVCapability(SpvCapabilityDenormFlushToZero); + // emitInst is used instead of requireSPIRVExecutionMode because + // we need to be able to emit the same execution mode with different + // operands for different widths + emitInst( + getSection(SpvLogicalSectionID::ExecutionModes), + decoration, + SpvOpExecutionMode, + dstID, + SpvExecutionModeDenormFlushToZero, + SpvLiteralInteger::from32(width)); + } + break; case kIROp_MaxVertexCountDecoration: // Don't do anything here, instead wait until we see OutputTopologyDecoration // and emit them together to ensure MaxVertexCount always appears before -- cgit v1.2.3