From ae04e604d43d169bcba7f24c8c23a0fdf4cbb483 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 18 Dec 2024 11:33:55 -0800 Subject: Allow `Optional`, `Tuple` and `bool` to be used in varying input/output. (#5889) * Allow `Optional` and `Tuple` to be used in varying input/output. * Fix. * format code * Fix. * Fix test. * Fix. * enhance test. * Fix. * format code --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- source/slang/slang-emit-spirv.cpp | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'source/slang/slang-emit-spirv.cpp') diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp index c618946ec..92fa507e0 100644 --- a/source/slang/slang-emit-spirv.cpp +++ b/source/slang/slang-emit-spirv.cpp @@ -1279,8 +1279,10 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex case AddressSpace::Uniform: return SpvStorageClassUniform; case AddressSpace::Input: + case AddressSpace::BuiltinInput: return SpvStorageClassInput; case AddressSpace::Output: + case AddressSpace::BuiltinOutput: return SpvStorageClassOutput; case AddressSpace::TaskPayloadWorkgroup: return SpvStorageClassTaskPayloadWorkgroupEXT; @@ -2688,7 +2690,10 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex IRBuilder builder(spvAsmBuiltinVar); builder.setInsertBefore(spvAsmBuiltinVar); auto varInst = getBuiltinGlobalVar( - builder.getPtrType(kIROp_PtrType, spvAsmBuiltinVar->getDataType(), AddressSpace::Input), + builder.getPtrType( + kIROp_PtrType, + spvAsmBuiltinVar->getDataType(), + AddressSpace::BuiltinInput), kind, spvAsmBuiltinVar); registerInst(spvAsmBuiltinVar, varInst); @@ -4214,7 +4219,9 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex { auto addrSpace = ptrType->getAddressSpace(); if (addrSpace != AddressSpace::Input && - addrSpace != AddressSpace::Output) + addrSpace != AddressSpace::Output && + addrSpace != AddressSpace::BuiltinInput && + addrSpace != AddressSpace::BuiltinOutput) continue; } } @@ -4995,7 +5002,7 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex if (!ptrType) return; auto addrSpace = ptrType->getAddressSpace(); - if (addrSpace == AddressSpace::Input) + if (addrSpace == AddressSpace::Input || addrSpace == AddressSpace::BuiltinInput) { if (isIntegralScalarOrCompositeType(ptrType->getValueType())) { -- cgit v1.2.3