From 9d47a352960efd71494c7dfa0918debd5b405077 Mon Sep 17 00:00:00 2001 From: Yong He Date: Mon, 21 Jul 2025 21:35:44 -0700 Subject: Fix Conditioanl fields with a semantic. (#7855) * Fix Conditioanl fields with a semantic. * Add unit test. * Fix test. --- source/slang/slang-check-overload.cpp | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'source/slang/slang-check-overload.cpp') diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp index 52b0ef5bc..18fb9798b 100644 --- a/source/slang/slang-check-overload.cpp +++ b/source/slang/slang-check-overload.cpp @@ -270,12 +270,31 @@ bool SemanticsVisitor::TryCheckOverloadCandidateVisibility( return true; } +static bool isArrayDecl(Decl* decl) +{ + if (auto magicMod = decl->findModifier()) + { + if (magicMod->magicNodeType.getTag() == ASTNodeType::ArrayExpressionType) + return true; + } + return false; +} + bool SemanticsVisitor::TryCheckGenericOverloadCandidateTypes( OverloadResolveContext& context, OverloadCandidate& candidate) { auto genericDeclRef = candidate.item.declRef.as(); + // All generic arguments, except array sizes, need to be at least a link-time constant. + // Exception: array sizes can also be a specialization constant. + // + ConstantFoldingKind argFoldingKind = ConstantFoldingKind::LinkTime; + if (isArrayDecl(genericDeclRef.getDecl())) + { + argFoldingKind = ConstantFoldingKind::SpecializationConstant; + } + // Only allow constructing a PartialGenericAppExpr when referencing a callable decl. // Other types of generic decls must be fully specified. bool allowPartialGenericApp = false; @@ -497,6 +516,7 @@ bool SemanticsVisitor::TryCheckGenericOverloadCandidateTypes( val = ExtractGenericArgInteger( arg, getType(m_astBuilder, valParamRef), + argFoldingKind, context.mode == OverloadResolveContext::Mode::JustTrying ? nullptr : getSink()); } -- cgit v1.2.3