From 19867ffca6dca7995c799354081219c9e76f13d1 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 20 Feb 2025 14:48:51 -0800 Subject: Simplify implicit cast ctors for vector & matrix. (#6408) * Simplify implicit cast ctors for vector & matrix. * Fix formatting. * Fix tests. * Fix Falcor test. * Mark __builtin_cast as internal. --- source/slang/slang-check-overload.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'source/slang/slang-check-overload.cpp') diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp index b944d2bf4..b75f95f9a 100644 --- a/source/slang/slang-check-overload.cpp +++ b/source/slang/slang-check-overload.cpp @@ -1675,6 +1675,15 @@ int SemanticsVisitor::CompareOverloadCandidates(OverloadCandidate* left, Overloa if (itemDiff) return itemDiff; + // If one candidate is an implicit conversion, and other candidate is not, + // then we should prefer the implicit conversion. + int leftIsImplicitConversion = + left->item.declRef.getDecl()->findModifier() ? 1 : 0; + int rightIsImplicitConversion = + right->item.declRef.getDecl()->findModifier() ? 1 : 0; + if (leftIsImplicitConversion != rightIsImplicitConversion) + return rightIsImplicitConversion - leftIsImplicitConversion; + auto specificityDiff = compareOverloadCandidateSpecificity(left->item, right->item); if (specificityDiff) return specificityDiff; -- cgit v1.2.3