From c43f6fa55aca23365c86c6ec1737d42be74d9d3e Mon Sep 17 00:00:00 2001
From: Yong He <yonghe@outlook.com>
Date: Tue, 7 Jan 2025 22:26:31 -0800
Subject: Lower varying parameters as pointers instead of SSA values. (#5919)

* Add executable test on matrix-typed vertex input.
* Fix emit logic of matrix layout qualifier.
* Pass fragment shader varying input by constref to allow EvaluateAttributeAtCentroid etc. to be implemented correctly.
---
 source/slang/slang-check-expr.cpp | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

(limited to 'source/slang/slang-check-expr.cpp')

diff --git a/source/slang/slang-check-expr.cpp b/source/slang/slang-check-expr.cpp
index 83b668a33..95d5a2a7c 100644
--- a/source/slang/slang-check-expr.cpp
+++ b/source/slang/slang-check-expr.cpp
@@ -4099,6 +4099,15 @@ Expr* SemanticsVisitor::maybeDereference(Expr* inExpr, CheckBaseContext checkBas
             elementType = QualType(ptrType->getValueType());
             elementType.isLeftValue = true;
         }
+        else
+        {
+            auto newExpr = maybeOpenRef(expr);
+            if (newExpr != expr)
+            {
+                expr = newExpr;
+                continue;
+            }
+        }
         if (elementType.type)
         {
             auto derefExpr = m_astBuilder->create<DerefExpr>();
@@ -4108,9 +4117,10 @@ Expr* SemanticsVisitor::maybeDereference(Expr* inExpr, CheckBaseContext checkBas
             expr = derefExpr;
             continue;
         }
-        // Default case: just use the expression as-is
-        return expr;
+        break;
     }
+    // Default case: just use the expression as-is
+    return expr;
 }
 
 Expr* SemanticsVisitor::CheckMatrixSwizzleExpr(
-- 
cgit v1.2.3