From bfac247ff2489a1f7fb9766674a6ed25a48a493b Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Sun, 8 Jun 2025 12:54:52 -0700 Subject: Fix interface types as RHS of is/as operators (#7234) Added error checking to reject interface types as the right-hand side of is and as operators. Enhanced semantic analysis with new diagnostic 30301 and comprehensive test coverage. --- source/slang/slang-check-expr.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'source/slang/slang-check-expr.cpp') diff --git a/source/slang/slang-check-expr.cpp b/source/slang/slang-check-expr.cpp index 66c2f9796..f4c8cd847 100644 --- a/source/slang/slang-check-expr.cpp +++ b/source/slang/slang-check-expr.cpp @@ -4065,6 +4065,13 @@ Expr* SemanticsExprVisitor::visitIsTypeExpr(IsTypeExpr* expr) expr->type = m_astBuilder->getBoolType(); expr->value = originalVal; + // Check if the right-hand side type is an interface type + if (isInterfaceType(expr->typeExpr.type)) + { + getSink()->diagnose(expr, Diagnostics::isAsOperatorCannotUseInterfaceAsRHS); + return expr; + } + auto valueType = expr->value->type.type; if (auto typeType = as(valueType)) valueType = typeType->getType(); @@ -4103,6 +4110,15 @@ Expr* SemanticsExprVisitor::visitAsTypeExpr(AsTypeExpr* expr) TypeExp typeExpr; typeExpr.exp = expr->typeExpr; typeExpr = CheckProperType(typeExpr); + + // Check if the right-hand side type is an interface type + if (isInterfaceType(typeExpr.type)) + { + getSink()->diagnose(expr, Diagnostics::isAsOperatorCannotUseInterfaceAsRHS); + expr->type = m_astBuilder->getErrorType(); + return expr; + } + expr->value = CheckTerm(expr->value); auto optType = m_astBuilder->getOptionalType(typeExpr.type); expr->type = optType; -- cgit v1.2.3